From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935768Ab3DPPu6 (ORCPT ); Tue, 16 Apr 2013 11:50:58 -0400 Received: from e28smtp04.in.ibm.com ([122.248.162.4]:53841 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933788Ab3DPPu5 (ORCPT ); Tue, 16 Apr 2013 11:50:57 -0400 Message-ID: <516D72B7.2040608@linux.vnet.ibm.com> Date: Tue, 16 Apr 2013 21:18:07 +0530 From: "Srivatsa S. Bhat" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Robin Holt CC: Ingo Molnar , Ingo Molnar , Russ Anderson , Shawn Guo , Oleg Nesterov , Andrew Morton , "H. Peter Anvin" , Joe Perches , Lai Jiangshan , Linus Torvalds , Linux Kernel Mailing List , Michel Lespinasse , "Paul E. McKenney" , Paul Mackerras , Peter Zijlstra , "rusty@rustcorp.com.au" , Tejun Heo , the arch/x86 maintainers , Thomas Gleixner Subject: Re: [Patch -v4 1/4] Migrate shutdown/reboot to boot cpu. References: <20130416095827.GJ3672@sgi.com> <20130416113256.GA10452@gmail.com> <20130416120624.GO3658@sgi.com> In-Reply-To: <20130416120624.GO3658@sgi.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13041615-5564-0000-0000-00000786CA13 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16/2013 05:36 PM, Robin Holt wrote: > On Tue, Apr 16, 2013 at 01:32:56PM +0200, Ingo Molnar wrote: >> >> * Robin Holt wrote: >> >>> We recently noticed that reboot of a 1024 cpu machine takes approx 16 >>> minutes of just stopping the cpus. The slowdown was tracked to commit >>> f96972f. >>> >>> The current implementation does all the work of hot removing the cpus >>> before halting the system. We are switching to just migrating to the >>> boot cpu and then continuing with shutdown/reboot. >>> >>> This also has the effect of not breaking x86's command line parameter for >>> specifying the reboot cpu. Note, this code was shamelessly copied from >>> arch/x86/kernel/reboot.c with bits removed pertaining to the reboot_cpu >>> command line parameter. >>> >>> Signed-off-by: Robin Holt >>> Tested-by: Shawn Guo >>> To: Ingo Molnar >>> To: Russ Anderson >>> To: Oleg Nesterov >>> Cc: Andrew Morton >>> Cc: "H. Peter Anvin" >>> Cc: Lai Jiangshan >>> Cc: Linus Torvalds >>> Cc: Linux Kernel Mailing List >>> Cc: Michel Lespinasse >>> Cc: Oleg Nesterov >>> Cc: "Paul E. McKenney" >>> Cc: Paul Mackerras >>> Cc: Peter Zijlstra >>> Cc: Robin Holt >>> Cc: "rusty@rustcorp.com.au" >>> Cc: Tejun Heo >>> Cc: the arch/x86 maintainers >>> Cc: Thomas Gleixner >>> Cc: >>> >>> --- >>> >>> Changes since -v1. >>> - Set PF_THREAD_BOUND before migrating to eliminate potential race. >>> - Modified kernel_power_off to also migrate instead of using >>> disable_nonboot_cpus(). >>> --- >>> kernel/sys.c | 22 +++++++++++++++++++--- >>> 1 file changed, 19 insertions(+), 3 deletions(-) >>> >>> diff --git a/kernel/sys.c b/kernel/sys.c >>> index 0da73cf..5ef7aa2 100644 >>> --- a/kernel/sys.c >>> +++ b/kernel/sys.c >>> @@ -357,6 +357,22 @@ int unregister_reboot_notifier(struct notifier_block *nb) >>> } >>> EXPORT_SYMBOL(unregister_reboot_notifier); >>> >>> +void migrate_to_reboot_cpu(void) >> >> It appears to be file-scope, so should be static I guess? > > Done. > >>> +{ >>> + /* The boot cpu is always logical cpu 0 */ >>> + int reboot_cpu_id = 0; >>> + >>> + /* Make certain the cpu I'm about to reboot on is online */ >>> + if (!cpu_online(reboot_cpu_id)) >>> + reboot_cpu_id = smp_processor_id(); >> >> Shouldn't we pick the first online CPU instead, to make it deterministic? > > Done. > > reboot_cpu_id = cpumask_first(cpu_online_mask); > Let me ask again: if CPU 0 (or whatever the preferred reboot cpu is) is offline, then why should we even bother pinning the task to (another) CPU? Why not just proceed with the reboot? Regards, Srivatsa S. Bhat