From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
davem@davemloft.net, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH] fec: Use SIMPLE_DEV_PM_OPS
Date: Tue, 16 Apr 2013 21:11:37 +0400 [thread overview]
Message-ID: <516D8649.4030604@cogentembedded.com> (raw)
In-Reply-To: <CAOMZO5CGn=aetDoo-oc3Ub3ZL=8RKsPzH6jkXvifykSnWrV_Rg@mail.gmail.com>
Hello.
On 16-04-2013 19:22, Fabio Estevam wrote:
>>> +static SIMPLE_DEV_PM_OPS(fec_pm_ops, fec_suspend, fec_resume);
>>> +#define FEC_PM_OPS (&fec_pm_ops)
>> Nit: parens are useless here.
> Have you tried removing parenthesis and run checkpatch?
Oops, I haven't.
> ERROR: Macros with complex values should be enclosed in parenthesis
> #45: FILE: drivers/net/ethernet/freescale/fec_main.c:1950:
> +#define FEC_PM_OPS &fec_pm_ops
Didn't know about this, sorry for the noise.
WBR, Sergei
next prev parent reply other threads:[~2013-04-16 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 13:58 [PATCH] fec: Use SIMPLE_DEV_PM_OPS Fabio Estevam
2013-04-16 14:32 ` Sergei Shtylyov
2013-04-16 15:22 ` Fabio Estevam
2013-04-16 17:11 ` Sergei Shtylyov [this message]
2013-04-16 17:49 ` Joe Perches
2013-04-16 17:51 ` Fabio Estevam
2013-04-16 21:25 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D8649.4030604@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.