All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: Ben Myers <bpm@sgi.com>
Cc: "xfs@oss.sgi.com" <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: don't return 0 if generic_segment_checks() find nothing to write
Date: Wed, 17 Apr 2013 02:35:54 +0800	[thread overview]
Message-ID: <516D9A0A.7060708@oracle.com> (raw)
In-Reply-To: <20130416182624.GK22182@sgi.com>

Hi Ben,

On 04/17/2013 02:26 AM, Ben Myers wrote:
> Hey Jeff,
> 
> On Fri, Apr 12, 2013 at 11:48:28PM +0800, Jeff Liu wrote:
>> From: Jie Liu <jeff.liu@oracle.com>
>>
>> At xfs_file_aio_write(), we just return 0 which means a successfully operation if the ocount
>> is evaluated to 0 at generic_segment_checks().  Generally, it'll occurred if the specified
>> write count is 0 from the user space.  However, for example, if the given offset is over the
>> maximum file size limitation although nothing would be written into the file, in this case,
>> the underlying file system should detect this issue and return a proper errno instead.
>> Hence, the beginning pre-checking up against ocount would conceal some real cause and confuse
>> the user space program maybe.
>>
>> To fix it, we can delay the write count verification until xfs_file_aio_write_checks() is done.
> 
> Could you wrap these around 72 columns or so in the future?  Don't worry
> about reposting this one unless something technical comes up.
Sure, I'll take care of the patch format in the future.

Thanks,
-Jeff

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-04-16 18:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-12 15:48 [PATCH] xfs: don't return 0 if generic_segment_checks() find nothing to write Jeff Liu
2013-04-16 18:26 ` Ben Myers
2013-04-16 18:35   ` Jeff Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516D9A0A.7060708@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=bpm@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.