From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V2] gpio: palmas: add dt support Date: Tue, 16 Apr 2013 12:44:59 -0600 Message-ID: <516D9C2B.302@wwwdotorg.org> References: <1366122705-3579-1-git-send-email-ldewangan@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1366122705-3579-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Laxman Dewangan Cc: linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, gg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org, ian-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org, j-keerthy-l0cyMroinI0@public.gmane.org, t-kristo-l0cyMroinI0@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 04/16/2013 08:31 AM, Laxman Dewangan wrote: > Add of_device_id table for Palma GPIO to be enable the > driver from DT file. > > The driver can be registered from DT file as: > palmas: tps65913@58 { > ::::::::::: > palmas_gpio: palmas_gpio { > compatible = "ti,palmas-gpio"; > gpio-controller; > #gpio-cells = <2>; > }; > }; So I think this patch looks fine if everyone is agreed that all the Palmas sub-modules are represented as explicit child nodes in DT, and the probing of the child nodes is based on the top-level Palmas device being a bus, and enumerating its children in standard DT style, using compatible values. (I'm not sure how the child probing/instantiation will work for non-DT systems though). I'm not 100% sure if an agreement on the top-level structure of the Palmas DT bindings was reached though? Can the SlimLogic people confirm this? I assume Laxman must be OK with it since he's sending this patch? It might be a good idea to get the final Palmas binding documentation reviewed and checked in before changing the drivers/.dts files to match what the final bindings might be. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754487Ab3DPSpG (ORCPT ); Tue, 16 Apr 2013 14:45:06 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:50272 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753786Ab3DPSpD (ORCPT ); Tue, 16 Apr 2013 14:45:03 -0400 Message-ID: <516D9C2B.302@wwwdotorg.org> Date: Tue, 16 Apr 2013 12:44:59 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Laxman Dewangan CC: linus.walleij@linaro.org, grant.likely@secretlab.ca, rob.herring@calxeda.com, gg@slimlogic.co.uk, ian@slimlogic.co.uk, j-keerthy@ti.com, t-kristo@ti.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, swarren@nvidia.com Subject: Re: [PATCH V2] gpio: palmas: add dt support References: <1366122705-3579-1-git-send-email-ldewangan@nvidia.com> In-Reply-To: <1366122705-3579-1-git-send-email-ldewangan@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/16/2013 08:31 AM, Laxman Dewangan wrote: > Add of_device_id table for Palma GPIO to be enable the > driver from DT file. > > The driver can be registered from DT file as: > palmas: tps65913@58 { > ::::::::::: > palmas_gpio: palmas_gpio { > compatible = "ti,palmas-gpio"; > gpio-controller; > #gpio-cells = <2>; > }; > }; So I think this patch looks fine if everyone is agreed that all the Palmas sub-modules are represented as explicit child nodes in DT, and the probing of the child nodes is based on the top-level Palmas device being a bus, and enumerating its children in standard DT style, using compatible values. (I'm not sure how the child probing/instantiation will work for non-DT systems though). I'm not 100% sure if an agreement on the top-level structure of the Palmas DT bindings was reached though? Can the SlimLogic people confirm this? I assume Laxman must be OK with it since he's sending this patch? It might be a good idea to get the final Palmas binding documentation reviewed and checked in before changing the drivers/.dts files to match what the final bindings might be.