From: Mark Jackson <mpfj-list@mimc.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add NanoBone board support
Date: Tue, 16 Apr 2013 20:31:19 +0100 [thread overview]
Message-ID: <516DA707.7030500@mimc.co.uk> (raw)
In-Reply-To: <20130416192752.GH11956@bill-the-cat>
On 16/04/13 20:27, Tom Rini wrote:
> On Tue, Apr 16, 2013 at 08:25:17PM +0100, Mark Jackson wrote:
>> On 16/04/13 20:14, Mark Jackson wrote:
>>> On 16/04/13 16:48, Tom Rini wrote:
>>>> On Tue, Apr 16, 2013 at 04:02:34PM +0100, Mark Jackson wrote:
>>
>> <snip>
>>
>>>>> +#define CONFIG_SYS_NAND_ECCTOTAL (CONFIG_SYS_NAND_ECCBYTES * \
>>>>> + CONFIG_SYS_NAND_ECCSTEPS)
>>>>> +
>>>>> +#define CONFIG_SYS_NAND_U_BOOT_START CONFIG_SYS_TEXT_BASE
>>>>
>>>> Another problem duplicated from am335x_evm.h :(
>>>
>>> I'll add it to the "remove duplicates" patch.
>>
>> Replied a bit too soon on this one ... I thought they were
>> duplicated, but they're not.
>>
>> what's the problem with these lines ?
>
> '#define<tab>' not '#define<space>'. A general fixup patch is fine.
Actually, neither CONFIG_SYS_NAND_ECCTOTAL nor CONFIG_SYS_NAND_ECCSTEPS
are used anywhere in the code !!
I'll just remove them.
next prev parent reply other threads:[~2013-04-16 19:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 15:02 [U-Boot] [PATCH] Add NanoBone board support Mark Jackson
2013-04-16 15:48 ` Tom Rini
2013-04-16 19:14 ` Mark Jackson
2013-04-16 19:22 ` Tom Rini
2013-04-22 10:04 ` Mark Jackson
2013-04-22 11:39 ` Mark Jackson
2013-04-16 19:25 ` Mark Jackson
2013-04-16 19:27 ` Tom Rini
2013-04-16 19:31 ` Mark Jackson [this message]
2013-04-19 20:58 ` Mark Jackson
2013-04-19 22:04 ` Tom Rini
2013-04-17 5:27 ` Hebbar, Gururaja
2013-04-17 17:42 ` Mark Jackson
2013-04-18 6:05 ` Hebbar, Gururaja
2013-04-18 6:20 ` Mark Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516DA707.7030500@mimc.co.uk \
--to=mpfj-list@mimc.co.uk \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.