Re: [Qemu-devel] [PATCH V12 02/18] block: distinguish id and name in bdrv_find_snapshot()

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1422 bytes --]

On 04/13/2013 02:56 AM, Wenchao Xia wrote:
>   To make it clear about id and name in searching, the API is changed
> a bit to distinguish them, and caller can choose to search by id or name.
> Searching will be done with higher priority of id. This function also
> returns negative value from bdrv_snapshot_list() instead of -ENOENT on
> error now.
>   Note that the logic is changed a bit: now it traverse twice, first search
> for id, second for name, but original code traverse only once to search
> them at the same time, so matching sequence may be different. As a result,
> do_savevm(), del_existing_snapshots(), load_vmsate() may behaviors differently
> if there are unwisely chosen name mixed with id. In do_info_snapshots(),
> the caller is changed to search id only, which should be the correct behavior.

I just realized that you are trying to do the same thing as Pavel, but
that your two implementations differ.

https://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03289.html

Rather than spending my time reviewing two competing versions, it would
be really nice if one of you could rebase patches on top of the other,
and present a unified series containing both of your improvements as a
single series, so that we are only changing bdrv_snapshot_list semantics
once.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]