All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: <dedekind1@gmail.com>
Cc: computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
	matthieu.castet@parrot.com
Subject: Re: [PATCH 08/11] mtd: add a new field for ecc info in the nand_flash_dev{}
Date: Wed, 17 Apr 2013 10:11:59 +0800	[thread overview]
Message-ID: <516E04EF.1020307@freescale.com> (raw)
In-Reply-To: <1366124195.23654.7.camel@sauron.fi.intel.com>

于 2013年04月16日 22:56, Artem Bityutskiy 写道:
> On Mon, 2013-03-18 at 19:18 +0800, Huang Shijie wrote:
>> +#define ECC_INFO(strength, size)	(((strength)<<  16) | (size))
>> +#define ECC_STRENGTH(x)			(((x)>>  16)&  0xffff)
>> +#define ECC_SIZE(x)			((x)&  0xffff)
>> +	uint32_t ecc_info;
>>   };
> Could you please avoid putting macro definition in the middle of the
> structure. Put it before the structure.
>
> Also, probably prefixing with NAND_ would make sense?
got it.

thanks
Huang Shijie

  reply	other threads:[~2013-04-17  2:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-18 11:18 [PATCH 00/11] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-03-18 11:18 ` [PATCH 01/11] " Huang Shijie
2013-03-18 11:18 ` [PATCH 02/11] mtd: increase max OOB size to 744 Huang Shijie
2013-03-18 11:18 ` [PATCH 03/11] mtd: get the ECC info from the parameter page for ONFI nand Huang Shijie
2013-03-18 11:18 ` [PATCH 04/11] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-04-22  4:24   ` Brian Norris
2013-04-22  6:24     ` Huang Shijie
2013-03-18 11:18 ` [PATCH 05/11] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-04-22  4:29   ` Brian Norris
2013-04-22  6:30     ` Huang Shijie
2013-03-18 11:18 ` [PATCH 06/11] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-03-18 11:18 ` [PATCH 07/11] mtd: replace the hardcode with the onfi_get_feature() Huang Shijie
2013-03-18 11:18 ` [PATCH 08/11] mtd: add a new field for ecc info in the nand_flash_dev{} Huang Shijie
2013-04-16 14:56   ` Artem Bityutskiy
2013-04-17  2:11     ` Huang Shijie [this message]
2013-03-18 11:18 ` [PATCH 09/11] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-03-18 11:18 ` [PATCH 10/11] mtd: add the ecc info for some " Huang Shijie
2013-04-22  3:30   ` Brian Norris
2013-03-18 11:18 ` [PATCH 11/11] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
2013-04-16 13:55 ` [PATCH 00/11] mtd: add datasheet's ECC information to nand_chip{} Artem Bityutskiy
2013-04-17  2:10   ` Huang Shijie
2013-04-17  3:56     ` Brian Norris
2013-04-22 21:35       ` Brian Norris
2013-04-23  2:34         ` Huang Shijie
2013-04-23  7:26           ` Brian Norris
2013-04-23  7:54             ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516E04EF.1020307@freescale.com \
    --to=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=matthieu.castet@parrot.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.