From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] net/cpsw: don't disable_irqs() after an interrupt has been received.
Date: Wed, 17 Apr 2013 09:44:44 +0200 [thread overview]
Message-ID: <516E52EC.60901@linutronix.de> (raw)
In-Reply-To: <516E3EED.4000200@ti.com>
On 04/17/2013 08:19 AM, Mugunthan V N wrote:
> When using cpsw_intr_disable, it actually only disables future interrupts
> from CPSW ip. But the current interrupt generated to interrupt controller
> will be still pending and will not allow ARM to do any thing till either
> interrups is disabled or acked, thus CPU will be in CPSW ISR continuously
> and system will hang. This patch is applicable only when kernel is always
> built with RT enabled which is not the current case in Vanilla kernel
I am not talking about RT, just threaded interrupts but yes I saw the
problem first with RT.
> I have tested this patch and it hangs the CPU after net open (CPSW init).
If I remove additionally the napi_schedule() piece then the network is
dead (as expected) and the system continues to work (and I receive
interrupts) and the ISR for cpsw is not executed again. What hardware /
CPU do you have?
>
> Regards
> Mugunthan V N
Sebastian
next prev parent reply other threads:[~2013-04-17 7:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 18:21 [PATCH] net/cpsw: don't disable_irqs() after an interrupt has been received Sebastian Andrzej Siewior
2013-04-17 6:19 ` Mugunthan V N
2013-04-17 7:44 ` Sebastian Andrzej Siewior [this message]
2013-04-17 8:46 ` Mugunthan V N
2013-04-17 9:02 ` Sebastian Andrzej Siewior
2013-04-17 10:08 ` Mugunthan V N
2013-04-17 10:49 ` Sebastian Andrzej Siewior
2013-04-17 11:44 ` Mugunthan V N
2013-04-17 11:55 ` D-Link DUB E100 C1 not working when pinged by "ping 172.17.0.1 -c 1 -s 1965" Dean Jenkins
2013-04-17 21:12 ` [PATCH] net/cpsw: don't disable_irqs() after an interrupt has been received Sebastian Andrzej Siewior
2013-04-17 9:19 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E52EC.60901@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.