From: "Frédéric DALLEAU" <frederic.dalleau@linux.intel.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v6 2/6] Bluetooth: Add bluetooth socket voice option
Date: Wed, 17 Apr 2013 09:45:27 +0200 [thread overview]
Message-ID: <516E5317.7070705@linux.intel.com> (raw)
In-Reply-To: <7D7C6747-5C34-41F2-8EC7-4855C5689643@holtmann.org>
Hello Marcel,
> wouldn't it be better if this default to the current controller setting. However I realize that the controller might be actually not yet present. So shouldn't we default to 0x0060 for CVSD.
For now, 0 is a placeholder. It maintains behavior for existing
code. BT_VOICE_CVSD is planned for S3, S2, S1 fallback for eSCO. But
IMHO, this needs some heavy interop testing. When interoperability is
ensured, BT_VOICE_CVSD could be used as default. The patch will be a
one liner.
Regards,
Frédéric
next prev parent reply other threads:[~2013-04-17 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 15:28 [PATCH v6 0/6] sco: SCO socket option for voice_setting Frédéric Dalleau
2013-04-16 15:28 ` [PATCH v6 1/6] Bluetooth: Move and rename hci_conn_accept Frédéric Dalleau
2013-04-16 17:41 ` Marcel Holtmann
2013-04-18 3:16 ` Gustavo Padovan
2013-04-16 15:28 ` [PATCH v6 2/6] Bluetooth: Add bluetooth socket voice option Frédéric Dalleau
2013-04-16 17:39 ` Marcel Holtmann
2013-04-17 7:45 ` Frédéric DALLEAU [this message]
2013-04-16 15:29 ` [PATCH v6 3/6] Bluetooth: Use hci_connect_sco directly Frédéric Dalleau
2013-04-16 17:42 ` Marcel Holtmann
2013-04-16 15:29 ` [PATCH v6 4/6] Bluetooth: Use voice setting in incoming SCO connection Frédéric Dalleau
2013-04-16 17:44 ` Marcel Holtmann
2013-04-16 15:29 ` [PATCH v6 5/6] Bluetooth: Parameters for outgoing SCO connections Frédéric Dalleau
2013-04-16 17:47 ` Marcel Holtmann
2013-04-16 15:29 ` [PATCH v6 6/6] Bluetooth: Fallback transparent SCO from T2 to T1 Frédéric Dalleau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516E5317.7070705@linux.intel.com \
--to=frederic.dalleau@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.