From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 2/3] drm/exynos: Rework fimc clocks handling Date: Wed, 17 Apr 2013 10:30:01 +0200 Message-ID: <516E5D89.2040305@samsung.com> References: <1366133486-22973-1-git-send-email-s.nawrocki@samsung.com> <1366133486-22973-3-git-send-email-s.nawrocki@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:13318 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965758Ab3DQIaF (ORCPT ); Wed, 17 Apr 2013 04:30:05 -0400 Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MLE00MHN4QTK580@mailout4.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 17 Apr 2013 09:30:02 +0100 (BST) In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sachin Kamat Cc: inki.dae@samsung.com, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree-discuss@lists.ozlabs.org On 04/17/2013 06:02 AM, Sachin Kamat wrote: > Hi Sylwester, > > On 16 April 2013 23:01, Sylwester Nawrocki wrote: >> @@ -1835,16 +1859,19 @@ static int fimc_probe(struct platform_device *pdev) >> ret = exynos_drm_ippdrv_register(ippdrv); >> if (ret < 0) { >> dev_err(dev, "failed to register drm fimc device.\n"); >> - goto err_ippdrv_register; >> + goto err_pm_dis; >> } >> >> dev_info(&pdev->dev, "drm fimc registered successfully.\n"); >> >> return 0; >> >> -err_ippdrv_register: >> +err_pm_dis: >> + devm_kfree(dev, ippdrv->prop_list); > > devm_kfree was removed in patch1 of this series. Do we need it back? Certainly not, that's a rebase error. I'll resend it fixed. Thanks for your review. Regards, Sylwester