All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: mrhines@linux.vnet.ibm.com
Cc: aliguori@us.ibm.com, quintela@redhat.com, mst@redhat.com,
	qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com,
	mrhines@us.ibm.com, gokul@us.ibm.com
Subject: Re: [Qemu-devel] [PULL v3 5/7] rdma: send pc.ram
Date: Wed, 17 Apr 2013 11:35:26 +0200	[thread overview]
Message-ID: <516E6CDE.8070509@redhat.com> (raw)
In-Reply-To: <1366172418-8729-6-git-send-email-mrhines@linux.vnet.ibm.com>

Il 17/04/2013 06:20, mrhines@linux.vnet.ibm.com ha scritto:
> +/*
> + * If a page (or a whole RDMA chunk) has been
> + * determined to be zero, then zap it.
> + */
> +void ram_handle_compressed(void *host, uint8_t ch, uint64_t size)
> +{
> +    memset(host, ch, TARGET_PAGE_SIZE);
> +#ifndef _WIN32
> +    if (ch == 0 && (!kvm_enabled() || kvm_has_sync_mmu()) &&
> +                            getpagesize() <= TARGET_PAGE_SIZE) {
> +        qemu_madvise(host, size, QEMU_MADV_DONTNEED);
> +    }
> +#endif
> +}
> +
>  static int ram_load(QEMUFile *f, void *opaque, int version_id)
>  {
>      ram_addr_t addr;
> @@ -837,14 +881,7 @@ static int ram_load(QEMUFile *f, void *opaque, int version_id)
>              }
>  
>              ch = qemu_get_byte(f);
> -            memset(host, ch, TARGET_PAGE_SIZE);
> -#ifndef _WIN32
> -            if (ch == 0 &&
> -                (!kvm_enabled() || kvm_has_sync_mmu()) &&
> -                getpagesize() <= TARGET_PAGE_SIZE) {
> -                qemu_madvise(host, TARGET_PAGE_SIZE, QEMU_MADV_DONTNEED);
> -            }
> -#endif
> +            ram_handle_compressed(host, ch, TARGET_PAGE_SIZE);
>          } else if (flags & RAM_SAVE_FLAG_PAGE) {
>              void *host;
>  

This part got squashed here.  Please put it in a separate patch as it
was in v2.

Paolo

  reply	other threads:[~2013-04-17  9:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17  4:20 [Qemu-devel] [PULL v3 0/7] rdma: migration support mrhines
2013-04-17  4:20 ` [Qemu-devel] [PULL v3 1/7] rdma: introduce qemu_ram_foreach_block mrhines
2013-04-17  4:20 ` [Qemu-devel] [PULL v3 2/7] rdma: new QEMUFileOps hooks mrhines
2013-04-17 10:13   ` Orit Wasserman
2013-04-17 10:17     ` Paolo Bonzini
2013-04-17 10:29       ` Orit Wasserman
2013-04-17 16:02     ` Michael R. Hines
2013-04-17  4:20 ` [Qemu-devel] [PULL v3 3/7] rdma: introduce capability for chunk registration mrhines
2013-04-17 15:44   ` Eric Blake
2013-04-17 16:00     ` Michael R. Hines
2013-04-17  4:20 ` [Qemu-devel] [PULL v3 4/7] rdma: core logic mrhines
2013-04-17  9:16   ` Paolo Bonzini
2013-04-17 18:44     ` Michael R. Hines
2013-04-17 11:20   ` Orit Wasserman
2013-04-17 14:09     ` Paolo Bonzini
2013-04-17 19:54     ` Michael R. Hines
2013-04-17  4:20 ` [Qemu-devel] [PULL v3 5/7] rdma: send pc.ram mrhines
2013-04-17  9:35   ` Paolo Bonzini [this message]
2013-04-17  4:20 ` [Qemu-devel] [PULL v3 6/7] rdma: print throughput while debugging mrhines
2013-04-17  4:20 ` [Qemu-devel] [PULL v3 7/7] rdma: add documentation mrhines
2013-04-17 15:52   ` Eric Blake
2013-04-17 16:01     ` Michael R. Hines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516E6CDE.8070509@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=abali@us.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=gokul@us.ibm.com \
    --cc=mrhines@linux.vnet.ibm.com \
    --cc=mrhines@us.ibm.com \
    --cc=mst@redhat.com \
    --cc=owasserm@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.