Re: [Qemu-devel] [PATCH v2 05/17] aio: stop using .io_flush()

[Paolo Bonzini <pbonzini@redhat.com>]

Il 17/04/2013 15:07, Stefan Hajnoczi ha scritto:
> 
> Due to this change we need to update tests/test-aio.c which asserts
> aio_poll() return values.  Note that QEMU doesn't actually rely on these
> return values so only tests/test-aio.c cares.
> 
> Note that ctx->notifier, the EventNotifier fd used for aio_notify(), is
> now handled as a special case.  This is a little ugly but maintains
> aio_poll() semantics, i.e. aio_notify() does not count as 'progress' and
> aio_poll() avoids blocking when the user has not set any fd handlers yet.
> 
> Patches after this remove .io_flush() handler code until we can finally
> drop the io_flush arguments to aio_set_fd_handler() and friends.

Dropping aio_poll()'s return value is ok (as a follow up).  The test
generally test for progress anyway with assertions on the results of the
notify callbacks.

Paolo