From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USUX1-00056A-8U for qemu-devel@nongnu.org; Wed, 17 Apr 2013 11:44:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USUWz-0008Ad-Sb for qemu-devel@nongnu.org; Wed, 17 Apr 2013 11:44:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USUWz-0008AI-Kd for qemu-devel@nongnu.org; Wed, 17 Apr 2013 11:44:21 -0400 Message-ID: <516EC351.3090205@redhat.com> Date: Wed, 17 Apr 2013 09:44:17 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366172418-8729-1-git-send-email-mrhines@linux.vnet.ibm.com> <1366172418-8729-4-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1366172418-8729-4-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2XWXTMGQWXICTFAJRDHUU" Subject: Re: [Qemu-devel] [PULL v3 3/7] rdma: introduce capability for chunk registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com Cc: aliguori@us.ibm.com, quintela@redhat.com, mst@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, abali@us.ibm.com, mrhines@us.ibm.com, gokul@us.ibm.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XWXTMGQWXICTFAJRDHUU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/16/2013 10:20 PM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > This capability allows you to disable dynamic chunk registration > for better throughput on high-performance links. >=20 > It is enabled by default. >=20 > Signed-off-by: Michael R. Hines > --- > +++ b/qapi-schema.json > @@ -602,7 +602,7 @@ > # Since: 1.2 Normally, I'd ask that you document the option above; something like: # @x-chunk-register-destination: do something (since 1.5) > ## > { 'enum': 'MigrationCapability', > - 'data': ['xbzrle'] } > + 'data': ['xbzrle', 'x-chunk-register-destination'] } But given the x- prefix, which is already a designation that the option is experimental and may be pulled, I can live without documentation here (where JUST the RDMA documentation, which mentions this capability, is sufficient). Therefore: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2XWXTMGQWXICTFAJRDHUU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRbsNRAAoJEKeha0olJ0NqqUwH/3P5jheAnDS+dTMPeAWjLryI hAPt3GboF/CfqfMp2HlBIX1k8UuPNaofPKO+g7ALcEFofGhw8guxo7SJKO0B8GuO M7TnM2mNPkUhYZ/miP6q5YXhi1spcOUyjP6AqFeMdIG8s63naK8+nntplmFyX26Y yHr6+W7GoDSt38AuRDvim09sWWvkN7MUbco0faH89S6NjBwJpeihhrDQ5RydqupG 5vun1VhexgU3h6nEoenoUP7Ic38NC8hwr+iEWGRUvOoXBZK7LGCOtyFJKiD0iPgQ GIEqpY9+JPZDsJ5YDe7zG0Q3W2eDqBGNXldcXOnpkG0f4l8vIdapnAPMPFgY9nk= =3C+w -----END PGP SIGNATURE----- ------enig2XWXTMGQWXICTFAJRDHUU--