From: Paolo Bonzini <pbonzini@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: amit.shah@redhat.com, aliguori@us.ibm.com,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix
Date: Wed, 17 Apr 2013 18:54:04 +0200 [thread overview]
Message-ID: <516ED3AC.9050907@redhat.com> (raw)
In-Reply-To: <516EC18E.7060702@redhat.com>
Il 17/04/2013 17:36, Hans de Goede ha scritto:
>>>
>>
>> I'm not sure why all users of qemu_chr_fe_add_watch believe that the
>> watch will be one-shot. This is definitely not what g_io_create_watch
>> does...
>
> It is supposed to depend on the return value of the callback, if you
> return False, then the source should be removed, in essence making
> the watch one-shot, see:
> http://www.gtk.org/api/2.6/glib/glib-The-Main-Event-Loop.html#GSourceFunc
Yeah, I found that later. :)
Paolo
prev parent reply other threads:[~2013-04-17 16:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 13:23 [Qemu-devel] [PATCH] qemu-char: another io_add_watch_poll fix Paolo Bonzini
2013-04-10 17:59 ` Amit Shah
2013-04-11 8:58 ` Paolo Bonzini
2013-04-12 9:24 ` Amit Shah
2013-04-12 10:31 ` Paolo Bonzini
2013-04-15 21:10 ` Anthony Liguori
2013-04-16 9:15 ` Gerd Hoffmann
2013-04-16 9:34 ` Paolo Bonzini
2013-04-17 15:36 ` Hans de Goede
2013-04-17 16:54 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516ED3AC.9050907@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=amit.shah@redhat.com \
--cc=hdegoede@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.