From: "Bengt Jönsson" <bengt.g.jonsson@stericsson.com>
To: Axel Lin <axel.lin@ingics.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Lee Jones <lee.jones@linaro.org>,
Yvan FILLION <yvan.fillion@stericsson.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] regulator: ab8500: Get rid of voltage_shift field from struct ab8500_regulator_info
Date: Thu, 18 Apr 2013 08:38:21 +0200 [thread overview]
Message-ID: <516F94DD.1040400@stericsson.com> (raw)
In-Reply-To: <1366210545.15800.2.camel@phoenix>
On 04/17/2013 04:55 PM, Axel Lin wrote:
> The voltage_shift can be calculated from voltage_mask.
> Let's remove voltage_shift fied from struct ab8500_regulator_info, this change
> can prevent missing voltage_shift setting issue.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Nice improvement.Thanks.
Acked-by: Bengt Jonsson <bengt.g.jonsson@stericsson.com>
next prev parent reply other threads:[~2013-04-18 6:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 14:54 [PATCH 1/2] regulator: ab8500: Remove unused voltage_shift field from struct expand_register Axel Lin
2013-04-17 14:55 ` [PATCH 2/2] regulator: ab8500: Get rid of voltage_shift field from struct ab8500_regulator_info Axel Lin
2013-04-18 6:38 ` Bengt Jönsson [this message]
2013-04-18 6:36 ` [PATCH 1/2] regulator: ab8500: Remove unused voltage_shift field from struct expand_register Bengt Jönsson
2013-04-18 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516F94DD.1040400@stericsson.com \
--to=bengt.g.jonsson@stericsson.com \
--cc=axel.lin@ingics.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yvan.fillion@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.