From: Jaehoon Chung <jh80.chung@samsung.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org,
will.newton@imgtec.com, jh80.chung@samsung.com,
Seungwon Jeon <tgih.jun@samsung.com>
Subject: Re: [PATCH] mmc: dw_mmc: clear INSTS register when initialize
Date: Thu, 18 Apr 2013 15:59:20 +0900 [thread overview]
Message-ID: <516F99C8.5020404@samsung.com> (raw)
In-Reply-To: <1366262497-22560-1-git-send-email-jy0922.shim@samsung.com>
Subject of this patch needs to modify from "INSTS" to "IDSTS".
add CC'd Seungwon
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
On 04/18/2013 02:21 PM, Joonyoung Shim wrote:
> If pending interrupt for IDMAC exists when probe, it will call interrupt
> handler unnecessarily.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
> ---
> drivers/mmc/host/dw_mmc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 323c502..b0057a2 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -2192,6 +2192,7 @@ int dw_mci_probe(struct dw_mci *host)
>
> /* Clear the interrupts for the host controller */
> mci_writel(host, RINTSTS, 0xFFFFFFFF);
> + mci_writel(host, IDSTS, 0xFFFFFFFF);
> mci_writel(host, INTMASK, 0); /* disable all mmc interrupt first */
>
> /* Put in max timeout */
> @@ -2243,6 +2244,7 @@ int dw_mci_probe(struct dw_mci *host)
> * receive ready and error such as transmit, receive timeout, crc error
> */
> mci_writel(host, RINTSTS, 0xFFFFFFFF);
> + mci_writel(host, IDSTS, 0xFFFFFFFF);
> mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
> SDMMC_INT_TXDR | SDMMC_INT_RXDR |
> DW_MCI_ERROR_FLAGS | SDMMC_INT_CD);
> @@ -2393,6 +2395,7 @@ int dw_mci_resume(struct dw_mci *host)
> mci_writel(host, FIFOTH, host->fifoth_val);
>
> mci_writel(host, RINTSTS, 0xFFFFFFFF);
> + mci_writel(host, IDSTS, 0xFFFFFFFF);
> mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
> SDMMC_INT_TXDR | SDMMC_INT_RXDR |
> DW_MCI_ERROR_FLAGS | SDMMC_INT_CD);
>
next prev parent reply other threads:[~2013-04-18 6:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 5:21 [PATCH] mmc: dw_mmc: clear INSTS register when initialize Joonyoung Shim
2013-04-18 6:59 ` Jaehoon Chung [this message]
2013-04-23 9:57 ` Seungwon Jeon
2013-04-23 10:23 ` Jaehoon Chung
2013-04-24 1:34 ` Seungwon Jeon
2013-04-24 3:05 ` Joonyoung Shim
2013-04-25 0:45 ` Jaehoon Chung
2013-04-25 7:49 ` Joonyoung Shim
2013-04-26 4:24 ` Seungwon Jeon
2013-04-26 5:18 ` Jaehoon Chung
2013-04-26 5:35 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516F99C8.5020404@samsung.com \
--to=jh80.chung@samsung.com \
--cc=cjb@laptop.org \
--cc=jy0922.shim@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.