From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57684) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjQ0-0004SP-Vi for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:38:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USjPz-00036Q-OU for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:38:08 -0400 Received: from mail-ee0-f51.google.com ([74.125.83.51]:46485) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USjPz-00036L-Fi for qemu-devel@nongnu.org; Thu, 18 Apr 2013 03:38:07 -0400 Received: by mail-ee0-f51.google.com with SMTP id c4so1094403eek.38 for ; Thu, 18 Apr 2013 00:38:06 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <516FA2C5.4030002@redhat.com> Date: Thu, 18 Apr 2013 09:37:41 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1366027532-1120-1-git-send-email-pbonzini@redhat.com> <1366027532-1120-2-git-send-email-pbonzini@redhat.com> <20130418053714.GE8997@redhat.com> In-Reply-To: <20130418053714.GE8997@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH uq/master v3 1/2] kvm: reset state from the CPU's reset method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: qemu-devel@nongnu.org, agraf@suse.de Il 18/04/2013 07:37, Gleb Natapov ha scritto: >> > +static inline void kvm_arch_reset_vcpu(CPUState *cs) >> > +{ >> > +} >> > + > You added stub to s390, but not to x86. It will compile either way with > current enough gcc, but I wonder why the inconsistency? > Because I kept it consistent within the file. s390 prefers stubs, x86 prefers no stubs. Paolo