From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Kazior Date: Thu, 18 Apr 2013 11:48:58 +0200 Subject: [ath9k-devel] [PATCH 1/5] ath10k: replace debug_mtx with conf_mutex In-Reply-To: <87ip3kqijo.fsf@kamboji.qca.qualcomm.com> References: <1366178645-13983-1-git-send-email-michal.kazior@tieto.com> <1366178645-13983-2-git-send-email-michal.kazior@tieto.com> <87ip3kqijo.fsf@kamboji.qca.qualcomm.com> Message-ID: <516FC18A.5050205@tieto.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 18/04/13 11:44, Kalle Valo wrote: > Michal Kazior writes: > >> It's not a good to have too many mutexes. The >> patch simplifies locking of debufs to use >> conf_mutex. >> >> Signed-off-by: Michal Kazior > > [...] > >> @@ -328,7 +328,7 @@ int ath10k_debug_create(struct ath10k *ar) >> return -ENOMEM; >> >> init_completion(&ar->debug.event_stats_compl); >> - mutex_init(&ar->debug.debug_mtx); >> + mutex_init(&ar->conf_mutex); > > Can this be right? We already initialise conf_mutex in core.c. Good catch, thanks! The mutex_init() is already initialized elsewhere. No need to re-initialize it here. -- Pozdrawiam / Best regards, Michal Kazior.