Re: [PATCH 3/5] ARM: dts: Add clock entries to G2D node for exynos4210

[Sylwester Nawrocki <s.nawrocki@samsung.com>]

Hi Sachin,

On 04/18/2013 01:15 PM, Sachin Kamat wrote:
> Added clock entries to G2D node.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
>  arch/arm/boot/dts/exynos4210.dtsi |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
> index 66e6b03..50ab9d4 100644
> --- a/arch/arm/boot/dts/exynos4210.dtsi
> +++ b/arch/arm/boot/dts/exynos4210.dtsi
> @@ -117,6 +117,8 @@
>  		compatible = "samsung,s5pv210-g2d";
>  		reg = <0x12800000 0x1000>;
>  		interrupts = <0 89 0>;
> +		clocks = <&clock 177>, <&clock 277>;
> +		clock-names = "sclk_fimg2d", "fimg2d";

Same clocks are used for exynos4210 and exynos4212/4412. Wouldn't
it work if you have added those properties to exynos4.dtsi, instead
of having same entries in exynos4210.dtsi and exynos4x12.dtsi  ?

Thanks,
Sylwester