From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56318) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USnfS-0003sQ-SS for qemu-devel@nongnu.org; Thu, 18 Apr 2013 08:10:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1USnfQ-0005iO-S1 for qemu-devel@nongnu.org; Thu, 18 Apr 2013 08:10:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1USnfQ-0005iB-Jb for qemu-devel@nongnu.org; Thu, 18 Apr 2013 08:10:20 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3ICAJkL002067 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 18 Apr 2013 08:10:20 -0400 Message-ID: <516FE2AB.5060304@redhat.com> Date: Thu, 18 Apr 2013 06:10:19 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366275680-15416-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1366275680-15416-1-git-send-email-kraxel@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2AHKRACFWAQRVMBRWITXV" Subject: Re: [Qemu-devel] [RfC PATCH 0/5] console: qom-ify & extent screendump monitor command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2AHKRACFWAQRVMBRWITXV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/18/2013 03:01 AM, Gerd Hoffmann wrote: > Hi, >=20 > This patch qom-ifies the QemuConsoles and adds an new, optional > parameter to the screendump command to specify the device you > want dump from. >=20 > Question for the QOM guys: where in the tree should the QemuConsoles > show up? I can't find anything in the tree doing this. I've placed > them below /backend. See patch #2. Ok? Better suggestions? >=20 > Question for the libvirt guys: Is it ok for libvirt to just extend the= > existing screendump command? Can libvirt figure there is a new > (optional) parameter? See patch #5. The existing libvirt API is: char * virDomainScreenshot(virDomainPtr domain, virStreamPtr stream, unsigned int screen, unsigned int flags) which uses the screen argument to distinguish both between devices and heads on a given device: * The screen ID is the sequential number of screen. In case of multiple * graphics cards, heads are enumerated before devices, e.g. having * two graphics cards, both with four heads, screen ID 5 addresses * the second head on the second card. So yes, I think libvirt will be able to drive the new command by knowing how many heads appear per device, then passing in the appropriate named device to the QMP command. And yes, I'll review patch 5 regarding interface design. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2AHKRACFWAQRVMBRWITXV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRb+KrAAoJEKeha0olJ0NqHbAIALCPmzbQ5oX8jfllrLazj9yK jQO37UNcN2liC7lQvkfYrKlmyBQOMPLBPQvQLgUaiHm8mwMxsSqX2F/+1ALOCeST 0XMfnIQ4ZsMe3NPQJiPvGNLMD/lgN5xPrKYBv9WNdLqIQkjmkCox36xyDQiLSKO0 az1pxjulmYX0i5WeNudWJ/AVPsRFFF/g61bCL5l7Zfdt0dUhHM7Oytykp5j/aDEW oeYvi9XMG8kjCK5Ld02Aboel21x7+dXgDpFB7SsQENQ8xDCVFsm6gI5nJ5VyZJlQ aVpEm3VO2tpZIu0iqDF8pw5Jbq6wq9wJRhpKz42jtFtST2fJS0lStQh/RVZvSxc= =hK4I -----END PGP SIGNATURE----- ------enig2AHKRACFWAQRVMBRWITXV--