From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: davem@davemloft.net, yongjun_wei@trendmicro.com.cn,
netdev@vger.kernel.org
Subject: Re: [PATCH] pkt_sched: fix error return code in fw_change_attrs()
Date: Thu, 18 Apr 2013 09:23:30 -0400 [thread overview]
Message-ID: <516FF3D2.7070402@mojatatu.com> (raw)
In-Reply-To: <CAPgLHd-cDj8j3tKofRMwJ8GE39LkO8ZvtTJ34aSFDSHO+7GjnA@mail.gmail.com>
On 13-04-17 10:49 PM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return -EINVAL when tb[TCA_FW_MASK] is set and head->mask != 0xFFFFFFFF
> instead of 0 (ifdef CONFIG_NET_CLS_IND and tb[TCA_FW_INDEV]), as done elsewhere
> in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Makes sense. I think i would have said something like:
"dont use the err code from tcf_change_indev() in case it succeeds to
report TCA_FW_MASK errors"
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
cheers,
jamal
next prev parent reply other threads:[~2013-04-18 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 2:49 [PATCH] pkt_sched: fix error return code in fw_change_attrs() Wei Yongjun
2013-04-18 2:50 ` David Miller
2013-04-18 2:56 ` yongjun_wei
2013-04-18 13:23 ` Jamal Hadi Salim [this message]
2013-04-19 21:35 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2013-04-18 2:37 Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516FF3D2.7070402@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.