Re: [cocci] Fixing the adjustment of variable declarations

[Markus Elfring <Markus.Elfring@web.de>]

> The semantic patch works on almost any code. However, it produces an
> incorrect transformation on the refs.c file
> https://github.com/git/git/blob/master/refs.c
>
> Doing
>
> spatch --sp-file sp.cocci refs.c -o refs.after.c
>
> An incorrect transformation is created:
…
> which erroneously changes the type of the variable r.
>
> Is it a bug


You found a detail which will hopefully trigger further collateral evolution.

Another test result:

Markus_Elfring@Sonne:…/Projekte/Coccinelle/Probe> spatch suggestion_for_Elia_Pinto-20221109.cocci expand_ref-test.c
…
@@ -1,6 +1,6 @@
 void my_expand_ref_variant(void)
 {
- const char **p, *r;
- for (p = ref_rev_parse_rules; *p; ++p)
+ const char **r;
+ for (const char **p = ref_rev_parse_rules; *p; ++p)
  { /* loop content */ }
 }


> or should the semantic patch be done better?

How do you think about software development possibilities with the following
script variant for the semantic patch language?


@movement@
type T;
identifier I;
statement S;
expression E1, E2, E3;
@@
(
-T I = E1;
 ... when != I
 for (
+     T
      I = E1; E2; E3
     )
 S
 ... when != I
|
-T I;
 ... when != I
 for (
+     T
      I = E1; E2; E3
     )
 S
 ... when != I
)


Regards,
Markus