From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH v4 02/10] ASoC: imx-pcm-dma: DT support Date: Thu, 18 Apr 2013 16:43:43 +0200 Message-ID: <5170069F.4030200@metafoo.de> References: <1366288424-7660-1-git-send-email-mpa@pengutronix.de> <1366288424-7660-3-git-send-email-mpa@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-194.synserver.de (smtp-out-199.synserver.de [212.40.185.199]) by alsa0.perex.cz (Postfix) with ESMTP id 447A3264F00 for ; Thu, 18 Apr 2013 16:44:31 +0200 (CEST) In-Reply-To: <1366288424-7660-3-git-send-email-mpa@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Markus Pargmann Cc: Fabio Estevam , alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org, Mark Brown , Timur Tabi , Liam Girdwood , Grant Likely , Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On 04/18/2013 02:33 PM, Markus Pargmann wrote: > This patch adds the possibility to pass a of_node as platform_data which > is used by generic-pcm-dma to request a DMA slave channel. > > Signed-off-by: Markus Pargmann > --- > sound/soc/fsl/imx-pcm-dma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c > index c246fb5..8945d22 100644 > --- a/sound/soc/fsl/imx-pcm-dma.c > +++ b/sound/soc/fsl/imx-pcm-dma.c > @@ -62,9 +62,11 @@ static const struct snd_dmaengine_pcm_config imx_dmaengine_pcm_config = { > > int imx_pcm_dma_init(struct platform_device *pdev) > { > + if (pdev->dev.platform_data) > + pdev->dev.of_node = pdev->dev.platform_data; In my opinion it's better to use pdev->dev.parent->of_node here. In the ssi driver you use platform_device_register_data, which will create a copy of the of_node you pass in as platform data. I'm not quite sure how well this will work. If you want to continue to use platform_data you should at least change the code in the ssi driver to not make a copy of the of_node. - Lars > + > return snd_dmaengine_pcm_register(&pdev->dev, &imx_dmaengine_pcm_config, > SND_DMAENGINE_PCM_FLAG_NO_RESIDUE | > - SND_DMAENGINE_PCM_FLAG_NO_DT | > SND_DMAENGINE_PCM_FLAG_COMPAT); > } > From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Thu, 18 Apr 2013 16:43:43 +0200 Subject: [alsa-devel] [PATCH v4 02/10] ASoC: imx-pcm-dma: DT support In-Reply-To: <1366288424-7660-3-git-send-email-mpa@pengutronix.de> References: <1366288424-7660-1-git-send-email-mpa@pengutronix.de> <1366288424-7660-3-git-send-email-mpa@pengutronix.de> Message-ID: <5170069F.4030200@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/18/2013 02:33 PM, Markus Pargmann wrote: > This patch adds the possibility to pass a of_node as platform_data which > is used by generic-pcm-dma to request a DMA slave channel. > > Signed-off-by: Markus Pargmann > --- > sound/soc/fsl/imx-pcm-dma.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/imx-pcm-dma.c b/sound/soc/fsl/imx-pcm-dma.c > index c246fb5..8945d22 100644 > --- a/sound/soc/fsl/imx-pcm-dma.c > +++ b/sound/soc/fsl/imx-pcm-dma.c > @@ -62,9 +62,11 @@ static const struct snd_dmaengine_pcm_config imx_dmaengine_pcm_config = { > > int imx_pcm_dma_init(struct platform_device *pdev) > { > + if (pdev->dev.platform_data) > + pdev->dev.of_node = pdev->dev.platform_data; In my opinion it's better to use pdev->dev.parent->of_node here. In the ssi driver you use platform_device_register_data, which will create a copy of the of_node you pass in as platform data. I'm not quite sure how well this will work. If you want to continue to use platform_data you should at least change the code in the ssi driver to not make a copy of the of_node. - Lars > + > return snd_dmaengine_pcm_register(&pdev->dev, &imx_dmaengine_pcm_config, > SND_DMAENGINE_PCM_FLAG_NO_RESIDUE | > - SND_DMAENGINE_PCM_FLAG_NO_DT | > SND_DMAENGINE_PCM_FLAG_COMPAT); > } >