All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
To: Josh Triplett <josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org>
Cc: Matt Fleming
	<matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>,
	Bryan O'Donoghue
	<bryan.odonoghue.lkml-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>,
	matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Darren Hart <darren.hart-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	Josh Boyer <jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] Remove warning in efi_enter_virtual_mode
Date: Thu, 18 Apr 2013 09:38:04 -0700	[thread overview]
Message-ID: <5170216C.9020300@zytor.com> (raw)
In-Reply-To: <20130418163325.GA6884@leaf>

On 04/18/2013 09:33 AM, Josh Triplett wrote:
> On Thu, Apr 18, 2013 at 12:00:26PM +0100, Matt Fleming wrote:
>>> No, no - we *don't* have a BGRT object at all.
>>>
>>> We have a completely clean memory map - but the BGRT code is causing the
>>> is_ram() failure.
>>  
>> You assume that mapping of the Boot Services regions is done purely for
>> the benefit of pulling out the bgrt image - it's not, see the above
>> commit log - and I assumed that you had an ACPI bgrt pointer in your
>> memory map, but you don't.
>>
>> Darren, Josh, have you ever seen an i386 machine with a bgrt pointer? If
>> not, and given that we've never seen an i386 firmware that requires the
>> above workaround from Matthew, combined with the fact that there are so
>> few i386 implementations out there, I'm inclined to apply the patch
>> below, because anything else is a lot more work. We can address this
>> properly if we ever start seeing i386 machines with bgrt pointers that
>> reference highmem.
> 
> The machine I developed the BGRT changes on kept the image below the 4G
> mark, inside one of the memory regions reclaimable via
> ExitBootServices().
> 

Well, highmem is >= ~896M.  Do you have a machine with BGRT over the
highmem mark?

	-hpa

WARNING: multiple messages have this Message-ID (diff)
From: "H. Peter Anvin" <hpa@zytor.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Matt Fleming <matt@console-pimps.org>,
	"Bryan O'Donoghue" <bryan.odonoghue.lkml@nexus-software.ie>,
	matthew.garrett@nebula.com, linux-efi@vger.kernel.org,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	Darren Hart <darren.hart@intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Josh Boyer <jwboyer@redhat.com>
Subject: Re: [PATCH] Remove warning in efi_enter_virtual_mode
Date: Thu, 18 Apr 2013 09:38:04 -0700	[thread overview]
Message-ID: <5170216C.9020300@zytor.com> (raw)
In-Reply-To: <20130418163325.GA6884@leaf>

On 04/18/2013 09:33 AM, Josh Triplett wrote:
> On Thu, Apr 18, 2013 at 12:00:26PM +0100, Matt Fleming wrote:
>>> No, no - we *don't* have a BGRT object at all.
>>>
>>> We have a completely clean memory map - but the BGRT code is causing the
>>> is_ram() failure.
>>  
>> You assume that mapping of the Boot Services regions is done purely for
>> the benefit of pulling out the bgrt image - it's not, see the above
>> commit log - and I assumed that you had an ACPI bgrt pointer in your
>> memory map, but you don't.
>>
>> Darren, Josh, have you ever seen an i386 machine with a bgrt pointer? If
>> not, and given that we've never seen an i386 firmware that requires the
>> above workaround from Matthew, combined with the fact that there are so
>> few i386 implementations out there, I'm inclined to apply the patch
>> below, because anything else is a lot more work. We can address this
>> properly if we ever start seeing i386 machines with bgrt pointers that
>> reference highmem.
> 
> The machine I developed the BGRT changes on kept the image below the 4G
> mark, inside one of the memory regions reclaimable via
> ExitBootServices().
> 

Well, highmem is >= ~896M.  Do you have a machine with BGRT over the
highmem mark?

	-hpa



  reply	other threads:[~2013-04-18 16:38 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-16 15:58 [PATCH] Remove warning in efi_enter_virtual_mode Bryan O'Donoghue
2013-04-16 15:58 ` Bryan O'Donoghue
     [not found] ` <1366127886-31460-1-git-send-email-bryan.odonoghue.lkml-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>
2013-04-17 14:06   ` Matt Fleming
2013-04-17 14:06     ` Matt Fleming
     [not found]     ` <516EAC4A.6040202-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-17 22:00       ` Bryan O'Donoghue
2013-04-17 22:00         ` Bryan O'Donoghue
     [not found]         ` <516F1B90.9040508-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>
2013-04-18 11:00           ` Matt Fleming
2013-04-18 11:00             ` Matt Fleming
     [not found]             ` <516FD24A.3070502-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-18 13:40               ` Josh Boyer
2013-04-18 13:40                 ` Josh Boyer
     [not found]                 ` <20130418134059.GF18383-dHPIJuKSOV01V+h/cAXI7w8O6CCKKCg3HZ5vskTnxNA@public.gmane.org>
2013-04-18 15:01                   ` Matthew Garrett
2013-04-18 15:01                     ` Matthew Garrett
     [not found]                     ` <1366297271.13667.14.camel-+5W/JHIUVxg@public.gmane.org>
2013-04-18 15:17                       ` Josh Boyer
2013-04-18 15:17                         ` Josh Boyer
2013-04-18 22:07               ` Bryan O'Donoghue
2013-04-18 22:07                 ` Bryan O'Donoghue
     [not found]                 ` <51706E8A.7030909-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org>
2013-04-18 23:01                   ` Josh Triplett
2013-04-18 23:01                     ` Josh Triplett
2013-04-18 23:44                     ` H. Peter Anvin
2013-04-18 23:44                       ` H. Peter Anvin
2013-04-18 23:42                   ` H. Peter Anvin
2013-04-18 23:42                     ` H. Peter Anvin
2013-04-18 14:51             ` Darren Hart
     [not found]               ` <51700876.1000305-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-04-18 16:19                 ` Matt Fleming
2013-04-18 16:19                   ` Matt Fleming
2013-04-19  0:18                   ` Darren Hart
     [not found]                     ` <51708D3D.9010707-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-04-19  7:50                       ` Matt Fleming
2013-04-19  7:50                         ` Matt Fleming
     [not found]                         ` <5170F736.2060803-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-19 12:01                           ` Josh Boyer
2013-04-19 12:01                             ` Josh Boyer
2013-09-10 17:43                           ` Darren Hart
2013-09-10 17:43                             ` Darren Hart
     [not found]                             ` <1378835007.19978.125.camel-d05DLm829JQHkdubuh725LKMmGWinSIL2HeeBUIffwg@public.gmane.org>
2013-09-12  7:55                               ` Matt Fleming
2013-09-12  7:55                                 ` Matt Fleming
     [not found]                                 ` <20130912075500.GC895-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-09-12 22:30                                   ` Darren Hart
2013-09-12 22:30                                     ` Darren Hart
2013-04-18 16:33             ` Josh Triplett
2013-04-18 16:38               ` H. Peter Anvin [this message]
2013-04-18 16:38                 ` H. Peter Anvin
2013-04-18 16:44                 ` Josh Triplett
2013-04-18 19:55                   ` Matt Fleming
2013-04-18 19:55                     ` Matt Fleming
     [not found]                     ` <51704FA8.7060801-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>
2013-04-18 19:57                       ` H. Peter Anvin
2013-04-18 19:57                         ` H. Peter Anvin
2013-04-18 19:58                       ` Matthew Garrett
2013-04-18 19:58                         ` Matthew Garrett
     [not found]                         ` <1366315083.13667.19.camel-+5W/JHIUVxg@public.gmane.org>
2013-04-18 20:11                           ` Darren Hart
2013-04-18 20:11                             ` Darren Hart
     [not found]                             ` <51705366.8070001-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-04-18 20:13                               ` H. Peter Anvin
2013-04-18 20:13                                 ` H. Peter Anvin
     [not found]                                 ` <517053EF.2030900-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-04-18 20:17                                   ` Darren Hart
2013-04-18 20:17                                     ` Darren Hart
     [not found]                                     ` <517054EF.9070500-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2013-04-18 20:45                                       ` H. Peter Anvin
2013-04-18 20:45                                         ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5170216C.9020300@zytor.com \
    --to=hpa-ymnouzjc4hwavxtiumwx3w@public.gmane.org \
    --cc=bryan.odonoghue.lkml-SyKdqv6vbfZdzvEItQ6vdLNAH6kLmebB@public.gmane.org \
    --cc=darren.hart-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org \
    --cc=jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
    --cc=matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org \
    --cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org \
    --cc=x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.