From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Thu, 18 Apr 2013 17:38:54 +0000 Subject: Re: [PATCH v2 1/2] ARM: shmobile: R8A7779: add Ether support Message-Id: <51702FAE.4040104@cogentembedded.com> List-Id: References: <201304042253.50662.sergei.shtylyov@cogentembedded.com> <20130418153611.GX14496@n2100.arm.linux.org.uk> In-Reply-To: <20130418153611.GX14496@n2100.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 18-04-2013 19:36, Russell King - ARM Linux wrote: >> +/* Ether */ >> +static struct resource ether_resources[] = { >> + { >> + .start = 0xfde00000, >> + .end = 0xfde003ff, >> + .flags = IORESOURCE_MEM, >> + }, { >> + .start = gic_iid(0xb4), >> + .flags = IORESOURCE_IRQ, >> + }, > There are macros for initializing these which have been around for a > few years now. I know, I know, just didn't know they're that old. > Please consider using them in future. This file uses the old style resource intializers generally, it just needs wholesale conversion. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Thu, 18 Apr 2013 21:38:54 +0400 Subject: [PATCH v2 1/2] ARM: shmobile: R8A7779: add Ether support In-Reply-To: <20130418153611.GX14496@n2100.arm.linux.org.uk> References: <201304042253.50662.sergei.shtylyov@cogentembedded.com> <20130418153611.GX14496@n2100.arm.linux.org.uk> Message-ID: <51702FAE.4040104@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 18-04-2013 19:36, Russell King - ARM Linux wrote: >> +/* Ether */ >> +static struct resource ether_resources[] = { >> + { >> + .start = 0xfde00000, >> + .end = 0xfde003ff, >> + .flags = IORESOURCE_MEM, >> + }, { >> + .start = gic_iid(0xb4), >> + .flags = IORESOURCE_IRQ, >> + }, > There are macros for initializing these which have been around for a > few years now. I know, I know, just didn't know they're that old. > Please consider using them in future. This file uses the old style resource intializers generally, it just needs wholesale conversion. WBR, Sergei