From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 10/17] ASoC: mxs: Use generic dmaengine PCM Date: Thu, 18 Apr 2013 19:46:08 +0200 Message-ID: <51703160.8080001@metafoo.de> References: <1366046404-8759-1-git-send-email-lars@metafoo.de> <1366046404-8759-11-git-send-email-lars@metafoo.de> <20130417084304.GK11245@S2101-09.ap.freescale.net> <516E6B2B.5000805@metafoo.de> <20130417135003.GA20563@S2101-09.ap.freescale.net> <516FB726.4080304@metafoo.de> <20130418150050.GE2222@S2101-09.ap.freescale.net> <51700B98.9030502@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-229.synserver.de (smtp-out-230.synserver.de [212.40.185.230]) by alsa0.perex.cz (Postfix) with ESMTP id 47D7B260309 for ; Thu, 18 Apr 2013 19:48:17 +0200 (CEST) In-Reply-To: <51700B98.9030502@metafoo.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Shawn Guo Cc: Ola Lilja , alsa-devel@alsa-project.org, Rajeev Kumar , Russell King , Ryan Mallon , Stephen Warren , Vinod Koul , Liam Girdwood , Peter Ujfalusi , Hartley Sweeten , Mark Brown , Laxman Dewangan , Sebastien Guiriec , Markus Pargmann , Lee Jones , Jarkko Nikula List-Id: alsa-devel@alsa-project.org On 04/18/2013 05:04 PM, Lars-Peter Clausen wrote: > On 04/18/2013 05:00 PM, Shawn Guo wrote: >> On Thu, Apr 18, 2013 at 11:04:38AM +0200, Lars-Peter Clausen wrote: >>> On 04/17/2013 03:50 PM, Shawn Guo wrote: >>>> On Wed, Apr 17, 2013 at 11:28:11AM +0200, Lars-Peter Clausen wrote: >>>>> Can you see whether the patch below fixes it? >>>>> >>>> No, it does not fix the problem. >>>> >>>> Shawn >>> >>> Could you try the other patch plus this one: >>> >> Yes, it works now. Thanks for the fixing, Lars. >> >> One small correction below on the first patch. >> > > Ok, thanks for testing. Will resent it with the two other patches later today. > > - Lars Hm, this is actually a bit more tricky. I missed that the direction of the SAIF is runtime programmable and not fixed. And while your probably won't switch between transmit and receive dynamically, whether a SAIF is used as transmitter or receiver is board specific. So I guess we need to add a devicetree property to describe this. - Lars