From: Stefan Weil <sw@weilnetz.de>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] block/ssh: Compilation fails on Debian squeeze
Date: Thu, 18 Apr 2013 22:42:09 +0200 [thread overview]
Message-ID: <51705AA1.5030300@weilnetz.de> (raw)
In-Reply-To: <1366316465-32710-1-git-send-email-sw@weilnetz.de>
Am 18.04.2013 22:21, schrieb Stefan Weil:
> Now gcc will check whether format string and variable arguments match.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> Please note: I could only run limited tests with the new code
> because ssh.c is currently not compiled in my w32/w64 environment.
>
> Regards,
> Stefan W.
The test fails on current Debian (squeeze), not because of wrong
format specifiers, but because of an "old" libssh2-1-dev.
ssh.c calls libssh2_session_handshake which was added in 1.2.8,
see http://www.libssh2.org/libssh2_session_handshake.html.
Can we simplify the libssh2 check in configure and require
pkg-config, no compile check?
Regards,
Stefan W.
next prev parent reply other threads:[~2013-04-18 20:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 20:21 [Qemu-trivial] [PATCH] block/ssh: Add missing gcc format attributes Stefan Weil
2013-04-18 20:21 ` [Qemu-devel] " Stefan Weil
2013-04-18 20:42 ` Stefan Weil [this message]
2013-04-18 21:08 ` [Qemu-devel] block/ssh: Compilation fails on Debian squeeze Richard W.M. Jones
2013-04-19 4:10 ` Stefan Weil
2013-04-18 21:07 ` [Qemu-trivial] [PATCH] block/ssh: Add missing gcc format attributes Richard W.M. Jones
2013-04-18 21:07 ` [Qemu-devel] " Richard W.M. Jones
2013-04-19 9:44 ` [Qemu-trivial] " Stefan Hajnoczi
2013-04-19 9:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51705AA1.5030300@weilnetz.de \
--to=sw@weilnetz.de \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.