Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

On 04/17/2013 05:07 PM, mrhines@linux.vnet.ibm.com wrote:
> From: "Michael R. Hines" <mrhines@us.ibm.com>
> 
> Code that does need to be visible is kept
> well contained inside this file and this is the only
> new additional file to the entire patch - good
> progress.
> 
> This file includes the entire protocol and interfaces
> required to perform RDMA migration.
> 
> Also, the configure and Makefile modifications to link
> this file are included.
> 
> Full documentation is in docs/rdma.txt

Which doesn't appear until later in the series?  If a git bisect lands
on this patch, I have to go out of my way to find the later commit that
adds the docs.

I personally like series that put the docs FIRST.  On initial review,
that gives the docs a chance for a clean-room review untainted by the
implementation choices; and leaves the docs fresh in reviewers' minds
during the rest of the series to validate that the implementation
matches docs.  On later review (such as git bisect landing here), it
means the docs are in-tree for any other commit that references them.
If it were me, I'd rebase things to put docs in patch 1 on the v5 series.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]