From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: marzen: keep local function as static
Date: Thu, 18 Apr 2013 22:39:54 +0000 [thread overview]
Message-ID: <5170763A.3030105@cogentembedded.com> (raw)
In-Reply-To: <87haj4s5yw.wl%kuninori.morimoto.gx@renesas.com>
Hello.
On 04/18/2013 10:33 AM, Kuninori Morimoto wrote:
> marzen_init_late() should be static
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/board-marzen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/board-marzen.c b/arch/arm/mach-shmobile/board-marzen.c
> index fac9e0f..ff8111b 100644
> --- a/arch/arm/mach-shmobile/board-marzen.c
> +++ b/arch/arm/mach-shmobile/board-marzen.c
> @@ -350,7 +350,7 @@ static struct platform_device *marzen_late_devices[] __initdata = {
> &ohci1_device,
> };
>
> -void __init marzen_init_late(void)
> +static void __init marzen_init_late(void)
Grr, I'm killing this function with my R8A7779 USB patchset!
You've only caused me to respin it extra time... although R8A7778
patchset needed a respin too. :-(
WBR, Sergei
prev parent reply other threads:[~2013-04-18 22:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-18 6:33 [PATCH] ARM: shmobile: marzen: keep local function as static Kuninori Morimoto
2013-04-18 13:36 ` Simon Horman
2013-04-18 22:39 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5170763A.3030105@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.