From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>,
Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: i2c-mxs woes
Date: Fri, 19 Apr 2013 14:07:13 +0200 [thread overview]
Message-ID: <51713371.6030805@free-electrons.com> (raw)
In-Reply-To: <1366372407.4146.3.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org>
Hi Lucas,
On 19/04/2013 13:53, Lucas Stach wrote:
> Hi Alexandre,
>
> Am Freitag, den 19.04.2013, 13:37 +0200 schrieb Alexandre Belloni:
>> Hi,
>>
>> I'm having some issues with the i2c-mxs driver in 3.9. Marek already
>> pointed me to the patches from Lucas and that greatly improved the
>> situation.
>>
>> For the context, my board has three nau7802 adcs, connected to a gpio
>> i2c-muxer, connected to i2c1.
>>
>> Here is what I observe:
>>
>> On 3.9:
>>
>> # time cat /sys/bus/iio/devices/iio:device1/in_voltage0_raw
>> 2620
>> real 0m 7.08s
>> user 0m 0.00s
>> sys 0m 0.02s
>> # time cat /sys/bus/iio/devices/iio:device1/in_voltage1_raw
>> 2623
>> real 0m 6.07s
>> user 0m 0.01s
>> sys 0m 0.01s
>> #
>>
> Is this with or without my patches? Before introduction of the error
> handling in PIO code there were a lot of situations where the controller
> would signal an error, but the driver would go on as usual, so the next
> transaction wouldn't succeed and stop for a whole second until the
> timeout hits and resets the controller.
This is with v2 of your patches. I applied "i2c-mxs remove races in PIO
code" and "i2c-mxs do error checking and handling in PIO mode"
Regards,
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2013-04-19 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 11:37 i2c-mxs woes Alexandre Belloni
[not found] ` <51712C8B.7070302-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2013-04-19 11:49 ` Marek Vasut
[not found] ` <201304191349.05971.marex-ynQEQJNshbs@public.gmane.org>
2013-04-19 12:05 ` Alexandre Belloni
2013-04-19 11:53 ` Lucas Stach
[not found] ` <1366372407.4146.3.camel-WzVe3FnzCwFR6QfukMTsflXZhhPuCNm+@public.gmane.org>
2013-04-19 12:07 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51713371.6030805@free-electrons.com \
--to=alexandre.belloni-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=marex-ynQEQJNshbs@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.