From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTAH9-00066d-KO for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:18:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTAH8-00010a-8v for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:18:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37120 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTAH8-00010Q-27 for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:18:46 -0400 Message-ID: <51713624.8050502@suse.de> Date: Fri, 19 Apr 2013 14:18:44 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366360066-3373-1-git-send-email-rth@twiddle.net> <51713463.4080300@suse.de> In-Reply-To: <51713463.4080300@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] tcg: Remove temp_buf List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, aurelien@aurel32.net Am 19.04.2013 14:11, schrieb Andreas F=E4rber: > Hi, >=20 > Am 19.04.2013 10:27, schrieb Richard Henderson: >> All targets have been converted to allocating space for temporaries >> on the stack. No need to allocate space within the CPU_COMMON block. >> >> Signed-off-by: Richard Henderson >> --- >> This depends on my tcg-arm patch set that's still outstanding. >=20 > My tree still has exactly one user in tcg/arm/, so once that disappears > feel free to add my Reviewed-by. Thanks for helping clean this up! >=20 > One question... >=20 >> >> >> r~ >> --- >> include/exec/cpu-defs.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h >> index d8c64e9..41f5b32 100644 >> --- a/include/exec/cpu-defs.h >> +++ b/include/exec/cpu-defs.h >> @@ -152,8 +152,6 @@ typedef struct CPUWatchpoint { >> memory was accessed */ = \ >> CPU_COMMON_TLB = \ >> struct TranslationBlock *tb_jmp_cache[TB_JMP_CACHE_SIZE]; = \ >> - /* buffer for temporaries in the code generator */ = \ >> - long temp_buf[CPU_TEMP_BUF_NLONGS]; = \ >=20 > Could CPU_TEMP_BUF_NLONGS be removed, too? More precisely, seeing that all targets actually still use it despite in most cases not actually accessing temp_buf, can you rename it to TCG_TEMP_STACK_NLONGS and move it to some TCG header as a follow-up pleas= e? Andreas >> = \ >> int64_t icount_extra; /* Instructions until next timer event. */= \ >> /* Number of cycles left, with interrupt flag in high bit. = \ >> --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg