From: Felix Fietkau <nbd@openwrt.org>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: linux-wireless@vger.kernel.org, johannes@sipsolutions.net
Subject: Re: [PATCH v3 2/3] mac80211/minstrel_ht: use the new rate control API
Date: Fri, 19 Apr 2013 16:52:16 +0200 [thread overview]
Message-ID: <51715A20.1080503@openwrt.org> (raw)
In-Reply-To: <20130419141645.GC8341@magnum.frso.rivierawaves.com>
On 2013-04-19 4:18 PM, Karl Beldan wrote:
> On Fri, Apr 19, 2013 at 03:01:16PM +0200, Felix Fietkau wrote:
>> + if (mp->hw->max_rates >= 2) {
>> + /*
>> + * At least 2 tx rates supported, use max_prob_rate next */
>>
> One \n too much.
>
>> @@ -907,8 +919,7 @@ minstrel_ht_update_caps(void *priv, struct ieee80211_supported_band *sband,
>> if (!n_supported)
>> goto use_legacy;
>>
>> - /* init {mi,mi->groups[*]}->{max_tp_rate,max_tp_rate2,max_prob_rate} */
>> - minstrel_ht_update_stats(mp, mi);
> We need to keep it.
Right, I intended to change the update_rates that I had in there to
update_stats.
- Felix
next prev parent reply other threads:[~2013-04-19 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 13:01 [PATCH v3 1/3] mac80211: improve the rate control API Felix Fietkau
2013-04-19 13:01 ` [PATCH v3 2/3] mac80211/minstrel_ht: use the new " Felix Fietkau
2013-04-19 14:16 ` Karl Beldan
2013-04-19 14:52 ` Felix Fietkau [this message]
2013-04-19 13:01 ` [PATCH v3 3/3] mac80211/minstrel: " Felix Fietkau
2013-04-19 14:06 ` [PATCH v3 1/3] mac80211: improve the " Karl Beldan
2013-04-19 14:15 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51715A20.1080503@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=karl.beldan@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.