All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: linux-audit@redhat.com
Subject: Re: Possible bug compiling Audit 2.6.x against kernel headers older than 3.19
Date: Wed, 06 Jul 2016 18:52:31 -0400	[thread overview]
Message-ID: <5171900.Z2pvM0MseI@x2> (raw)
In-Reply-To: <CAFSsvmqbDWp=OjphAH6Tf7YC8q0phwCzm86aDz050-3kxAMnZw@mail.gmail.com>

On Wednesday, July 6, 2016 10:53:37 AM EDT Adam Duskett wrote:
> Audit 2.6.x checks for AUDIT_FEATURE_VERSION to be defined in
> include/linux/audit.h (this define was introduced in kernel version
> 3.13) and then blindly assumes that struct audit_status has
> feature_bitmap.
> 
> However this looks like a problem as feature_bitmap wasn't introduced
> until kernel 3.19, even though the requirements for Audit state that
> anything > 2.6.30 should work.  (http://people.redhat.com/sgrubb/audit/)

Yes, but this is obvious a mistake. :-)
 
> This causes a compile error when attempting to compile audit 2.6.x
> against kernel headers younger than 3.19.
> 
> libaudit.c:609:33: error: 'struct audit_status' has no member named
> 'feature_bitmap'
> features_bitmap = rep.status->feature_bitmap;

I think this is now fixed in svn. I don't know if you can try a pre-release or 
not. I'll probably do a new release in a few days.

-Steve

      reply	other threads:[~2016-07-06 22:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 14:53 Possible bug compiling Audit 2.6.x against kernel headers older than 3.19 Adam Duskett
2016-07-06 22:52 ` Steve Grubb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5171900.Z2pvM0MseI@x2 \
    --to=sgrubb@redhat.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.