All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: [PATCH 0/2] btrfs-progs: standardize utility filenames and add default rules to Makefile
Date: Sun, 21 Apr 2013 17:10:44 -0500	[thread overview]
Message-ID: <517463E4.7040400@redhat.com> (raw)

2 patches here.

The first renames the single .c files which are built into btrfs-$FOO
commands - previously we built i.e. btrfs-calc-size from calc-size.c

IMHO this helps separate out which files are main command-type
files, and which are not.  (Eventually I hope to move things
into subdirs to organize a bit more).

Then, after renaming i.e. calc-size.c to  btrfs-calc-size.c we can
write a simpler default rule for these utilities (patch 2/2).

The default static rule is handy because it'll automatically build
i.e. "make btrfs-image.static" or "make btrfs-calc-size.static"
if you need them.

I think this is a net win, with a bit less Makefile code
duplication, but if people don't like it, no big deal.  I was hoping
to clean up & re-organize the userspace build a little, and this
seems like a decent first step along the way.

Comments welcome, especially from people who are better at Make than
I am.  ;)  And if this is two clever by half I'm not wedded to it.

-Eric

             reply	other threads:[~2013-04-21 22:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-21 22:10 Eric Sandeen [this message]
2013-04-21 22:22 ` [PATCH 2/2] btrfs-progs: Add default rules to Makefile Eric Sandeen
2013-04-24 12:43   ` David Sterba
2013-04-23 16:09 ` [PATCH 0/2] btrfs-progs: standardize utility filenames and add " David Sterba
2013-04-23 16:48   ` Eric Sandeen
2013-04-23 20:57 ` [PATCH 1/2 (resend)] btrfs-progs: standardize tool source filenames Eric Sandeen
2013-04-24 12:21   ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517463E4.7040400@redhat.com \
    --to=sandeen@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.