From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] x86: Fix AMD K6 indirect call check v2
Date: Sun, 21 Apr 2013 15:35:41 -0700 [thread overview]
Message-ID: <517469BD.3060406@zytor.com> (raw)
In-Reply-To: <20130421174456.GA4559@pd.tnic>
On 04/21/2013 10:44 AM, Borislav Petkov wrote:
>
> But I have hard time understanding what that test with the 10^6 loop
> iterations is supposed to achieve. And what makes sure that the RDTSCs
> don't get reordered? Or maybe K6 wasn't reordering that aggressively...
>
> Erratum says "unpredictable system behavior" but it seems it wasn't that
> unpredictable after all - otherwise the fix would've been "HLT" right
> then and there. :)
>
Looks like it is just trying to sense the bug... but then it doesn't
actually do anything about it. At least it should taint the kernel.
-hpa
next prev parent reply other threads:[~2013-04-21 22:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-21 16:49 [PATCH] x86: Fix AMD K6 indirect call check v2 Andi Kleen
2013-04-21 17:06 ` H. Peter Anvin
2013-04-21 17:13 ` Andi Kleen
2013-04-21 17:44 ` Borislav Petkov
2013-04-21 22:35 ` H. Peter Anvin [this message]
2013-04-21 22:48 ` Borislav Petkov
2013-04-22 11:25 ` Wolfram Gloger
2013-04-22 12:58 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517469BD.3060406@zytor.com \
--to=hpa@zytor.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.