All of lore.kernel.org
 help / color / mirror / Atom feed
From: Donghwa Lee <dh09.lee@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] video: exynos_fb: Add the missing #else clause
Date: Mon, 22 Apr 2013 10:00:35 +0900	[thread overview]
Message-ID: <51748BB3.6010600@samsung.com> (raw)
In-Reply-To: <CAEC9eQOp4fUQE2HJvR-p_38N+PCmE3jN9dEi-u9oc00J64bLaw@mail.gmail.com>

It looks good to me.

Acked-by: Donghwa Lee <dh09.lee@samsung.com>

Thank you,
Donghwa Lee


On Mon, Apr 22, 2013 at 02:03, Ajay kumar wrote:
> ping.
>
>
> On Thu, Apr 4, 2013 at 7:55 PM, Ajay Kumar <ajaykumar.rs@samsung.com 
> <mailto:ajaykumar.rs@samsung.com>> wrote:
>
>     This patch fixes a bug introduced while adding DT support
>     to Exynos FIMD driver:
>
>             commit c23f3157d69bbb6c044256870f745f195b12431e
>             Author: Ajay Kumar <ajaykumar.rs@samsung.com
>     <mailto:ajaykumar.rs@samsung.com>>
>             Date:   Thu Feb 21 23:53:01 2013 +0000
>
>                 video: exynos_fb: add DT support for FIMD driver
>
>     Even though this part of code was missing, things were working
>     fine on Exynos5250 because, samsung_get_base_fimd() used
>     to give the correct base address for Exynos5250 FIMD.
>
>     Signed-off-by: Ajay Kumar <ajaykumar.rs@samsung.com
>     <mailto:ajaykumar.rs@samsung.com>>
>     ---
>      drivers/video/exynos_fimd.c | 3 ++-
>      1 file changed, 2 insertions(+), 1 deletion(-)
>
>     diff --git a/drivers/video/exynos_fimd.c b/drivers/video/exynos_fimd.c
>     index 3359949..7243ea3 100644
>     --- a/drivers/video/exynos_fimd.c
>     +++ b/drivers/video/exynos_fimd.c
>     @@ -280,8 +280,9 @@ void exynos_fimd_lcd_init(vidinfo_t *vid)
>         node, "reg");
>             if (fimd_ctrl == NULL)
>                     debug("Can't get the FIMD base address\n");
>     -#endif
>     +#else
>             fimd_ctrl = (struct exynos_fb *)samsung_get_base_fimd();
>     +#endif
>
>             offset = exynos_fimd_get_base_offset();
>
>     --
>     1.8.0
>
>     _______________________________________________
>     U-Boot mailing list
>     U-Boot at lists.denx.de <mailto:U-Boot@lists.denx.de>
>     http://lists.denx.de/mailman/listinfo/u-boot
>
>

  reply	other threads:[~2013-04-22  1:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-04 14:25 [U-Boot] [PATCH] video: exynos_fb: Add the missing #else clause Ajay Kumar
2013-04-21 17:03 ` Ajay kumar
2013-04-22  1:00   ` Donghwa Lee [this message]
2013-06-21  0:15     ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51748BB3.6010600@samsung.com \
    --to=dh09.lee@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.