All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <mason@suse.com>
To: linux-kernel@vger.kernel.org
Cc: viro@math.psu.edu
Subject: named pipe writes on readonly filesystems
Date: Mon, 12 Mar 2001 21:06:14 -0500	[thread overview]
Message-ID: <517520000.984449174@tiny> (raw)

Hello everyone,

Since fs/pipe.c:pipe_write() calls mark_inode_dirty, and it is legal to
write to a named pipe on a readonly filesystem, we can end up writing an
inode on a readonly FS.

reiserfs prints a warning whenever someone tries to write an inode on a
readonly FS, so we've been getting a few complaints about this.

I see at least 3 choices:

drop the reiserfs warning, it was only there to chase things similar to the
remount root readonly bug in 2.4.0.

change mark_inode_dirty or write_inode to exit early on readonly
filesystems.

change pipe_write to leave the inode clean when the FS is readonly.

Does anyone have a preference?  I'd rather not see each FS have to check
for this on their own, but the other filesystems aren't as picky as
reiserfs in this case ;-)

-chris


             reply	other threads:[~2001-03-13  2:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-13  2:06 Chris Mason [this message]
2001-03-13  2:15 ` named pipe writes on readonly filesystems Alexander Viro
2001-03-13  9:22   ` Ingo Oeser
2001-03-13  9:26     ` Alexander Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517520000.984449174@tiny \
    --to=mason@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.