All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Egger <chegger@amazon.de>
To: xen-devel <xen-devel@lists.xen.org>
Subject: [PATCH] tools/pygrub: do not override pygrub with a symbolic link
Date: Mon, 22 Apr 2013 13:50:03 +0200	[thread overview]
Message-ID: <517523EB.4030608@amazon.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

tools/pygrub: Do not override pygrub with a symbolic link if $(BINDIR) and $(PRIVATE_BINDIR) are the same.

Signed-off-by: Christoph Egger <chegger@amazon.de>
diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
index 039f7f7..c3b34d7 100644
--- a/tools/pygrub/Makefile
+++ b/tools/pygrub/Makefile
@@ -15,8 +15,8 @@ install: all
 		--install-scripts=$(PRIVATE_BINDIR) --force
 	$(INSTALL_DIR) $(DESTDIR)/var/run/xend/boot
 	set -e; if [ "`readlink -f $(DESTDIR)/$(BINDIR)`" != \
-	             "`readlink -f $(PRIVATE_BINDIR)`" ]; then \
-	    ln -sf $(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR); \
+	             "`readlink -f $(DESTDIR)/$(PRIVATE_BINDIR)`" ]; then \
+	    ln -sf $(DESTDIR)/$(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR); \
 	fi
 
 .PHONY: clean

[-- Attachment #2: patch_pygrub.diff --]
[-- Type: text/plain, Size: 919 bytes --]

commit 78128508937af187889806b9be3de0d49b8915fa
Author: Christoph Egger <chegger@amazon.de>
Date:   Fri Feb 8 12:44:12 2013 +0000

    tools/pygrub: Do not override pygrub with a symbolic link if $(BINDIR)
    and $(PRIVATE_BINDIR) are the same.
    
    Signed-off-by: Christoph Egger <chegger@amazon.de>

diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
index 039f7f7..c3b34d7 100644
--- a/tools/pygrub/Makefile
+++ b/tools/pygrub/Makefile
@@ -15,8 +15,8 @@ install: all
 		--install-scripts=$(PRIVATE_BINDIR) --force
 	$(INSTALL_DIR) $(DESTDIR)/var/run/xend/boot
 	set -e; if [ "`readlink -f $(DESTDIR)/$(BINDIR)`" != \
-	             "`readlink -f $(PRIVATE_BINDIR)`" ]; then \
-	    ln -sf $(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR); \
+	             "`readlink -f $(DESTDIR)/$(PRIVATE_BINDIR)`" ]; then \
+	    ln -sf $(DESTDIR)/$(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR); \
 	fi
 
 .PHONY: clean

[-- Attachment #3: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

             reply	other threads:[~2013-04-22 11:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22 11:50 Christoph Egger [this message]
2013-04-22 18:34 ` [PATCH] tools/pygrub: do not override pygrub with a symbolic link Matt Wilson
  -- strict thread matches above, loose matches on Subject: below --
2013-04-22 11:50 Christoph Egger
2013-04-22 11:58 ` Ian Campbell
2013-04-22 12:26   ` Christoph Egger
2013-04-22 12:34     ` Ian Campbell
2013-04-22 13:07       ` Christoph Egger
2013-04-22 14:31         ` Ian Campbell
2013-04-22 14:48           ` Christoph Egger
2013-04-22 18:36             ` Matt Wilson
2013-04-24 11:56               ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517523EB.4030608@amazon.de \
    --to=chegger@amazon.de \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.