From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH v2] tools/tests/mem-sharing/memshrtool share-all test Date: Mon, 22 Apr 2013 13:11:31 +0100 Message-ID: <517528F3.5080103@eu.citrix.com> References: <20130318133433.GA10286@gmail.com> <20130321121728.GC12338@ocelot.phlegethon.org> <1366632476.22143.53.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1366632476.22143.53.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Tamas Lengyel , Andres Lagar-Cavilla , "Tim (Xen.org)" , Andres Lagar-Cavilla , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 22/04/13 13:07, Ian Campbell wrote: > On Fri, 2013-03-22 at 19:25 +0000, Andres Lagar-Cavilla wrote: >> On Mar 21, 2013, at 8:17 AM, Tim Deegan wrote: >> >>> At 09:34 -0400 on 18 Mar (1363599276), Tamas Lengyel wrote: >>>> Update memshrtool test program to allow sharing of all pages of two domains >>>> with identical memory sizes. Currently the tool only allows sharing of >>>> specific pages. With this patch we can quickly share all pages between clones >>>> and check how many pages were successfully deduplicated. The pages' content >>>> are not checked, therefore this mode is only safe for clone domains. >>> Cc'ing Andres, who wrote the original tool. >>> >>> Tim. >>> >>>> v2: fix typo of source_info >>>> >>>> Signed-off-by: Tamas Lengyel >> Just a few minute comments. >> >> The code in itself is correct as a first attempt. I am tempted to ack >> it on the basis of being a useful thing. > Did you conclude that you would ack it in the end or not? > > WRT the freeze it seems this is new standalone functionality in a test > tool, which ought to be pretty safe. George CCd. I think this is a "just barely" in terms of timing / risk / benefits analysis, but: Acked-by: George Dunlap