All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: lager: Add GPIO LEDs
Date: Mon, 22 Apr 2013 12:27:06 +0000	[thread overview]
Message-ID: <51752C9A.2040508@cogentembedded.com> (raw)
In-Reply-To: <1366599990-31751-1-git-send-email-horms+renesas@verge.net.au>

Hello.

On 22-04-2013 7:06, Simon Horman wrote:

> The board has 3 LEDs connected to GPIOs. Add a led-gpio device to
> support them.

> Based on "ARM: shmobile: marzen: Add GPIO LEDs" by Laurent Pinchart.

> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>   arch/arm/mach-shmobile/board-lager.c | 37 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 37 insertions(+)

> Tested on lager board.
> Based on the tag renesas-next-20130419 of my renesas tree.

> diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> index 6114edd..a8aa04f 100644
> --- a/arch/arm/mach-shmobile/board-lager.c
> +++ b/arch/arm/mach-shmobile/board-lager.c
[...]
> @@ -46,6 +82,7 @@ static void __init lager_add_standard_devices(void)
>   	r8a7790_pinmux_init();
>
>   	r8a7790_add_standard_devices();
> +	platform_add_devices(lager_devices, ARRAY_SIZE(lager_devices));

    I thought we shouldn't use platform_add_devices() anymore, being close 
relative to platform_device_register()?

WBR, Sergei


WARNING: multiple messages have this Message-ID (diff)
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: lager: Add GPIO LEDs
Date: Mon, 22 Apr 2013 16:27:06 +0400	[thread overview]
Message-ID: <51752C9A.2040508@cogentembedded.com> (raw)
In-Reply-To: <1366599990-31751-1-git-send-email-horms+renesas@verge.net.au>

Hello.

On 22-04-2013 7:06, Simon Horman wrote:

> The board has 3 LEDs connected to GPIOs. Add a led-gpio device to
> support them.

> Based on "ARM: shmobile: marzen: Add GPIO LEDs" by Laurent Pinchart.

> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>   arch/arm/mach-shmobile/board-lager.c | 37 ++++++++++++++++++++++++++++++++++++
>   1 file changed, 37 insertions(+)

> Tested on lager board.
> Based on the tag renesas-next-20130419 of my renesas tree.

> diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> index 6114edd..a8aa04f 100644
> --- a/arch/arm/mach-shmobile/board-lager.c
> +++ b/arch/arm/mach-shmobile/board-lager.c
[...]
> @@ -46,6 +82,7 @@ static void __init lager_add_standard_devices(void)
>   	r8a7790_pinmux_init();
>
>   	r8a7790_add_standard_devices();
> +	platform_add_devices(lager_devices, ARRAY_SIZE(lager_devices));

    I thought we shouldn't use platform_add_devices() anymore, being close 
relative to platform_device_register()?

WBR, Sergei

  parent reply	other threads:[~2013-04-22 12:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-22  3:06 [PATCH] ARM: shmobile: lager: Add GPIO LEDs Simon Horman
2013-04-22  3:06 ` Simon Horman
2013-04-22  9:59 ` Laurent Pinchart
2013-04-22 10:00   ` Laurent Pinchart
2013-04-23  1:15   ` Simon Horman
2013-04-23  1:15     ` Simon Horman
2013-04-23 10:48     ` Laurent Pinchart
2013-04-23 10:48       ` Laurent Pinchart
2013-04-26  2:23       ` Simon Horman
2013-04-26  2:23         ` Simon Horman
2013-04-22 12:27 ` Sergei Shtylyov [this message]
2013-04-22 12:27   ` Sergei Shtylyov
2013-04-23  1:17   ` Simon Horman
2013-04-23  1:17     ` Simon Horman
2013-04-23  2:36     ` Simon Horman
2013-04-23  2:36       ` Simon Horman
2013-04-23  2:37 ` Simon Horman
2013-04-23  2:37   ` Simon Horman
2013-04-30  2:10   ` Simon Horman
2013-04-30  2:10     ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51752C9A.2040508@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.