From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Mon, 22 Apr 2013 13:34:05 +0000 Subject: Re: [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code Message-Id: <51753C4D.4080701@cogentembedded.com> List-Id: References: <201304200156.23830.sergei.shtylyov@cogentembedded.com> <51743BC0.20506@cogentembedded.com> <20130422010917.GC15680@verge.net.au> In-Reply-To: <20130422010917.GC15680@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 22-04-2013 5:09, Simon Horman wrote: >>> USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and >>> registered in the Marzen board file. Move the data and code to their proper >>> place in setup-r8a7779.c; while at it, we have to rename 8a7779_late_devices[] >>> to 8a7779_standard_devices[] -- this seems legitimate since they are registered >> >> I've been pointed to the types in the above variable names privately. >> Don't know should I resend or Simon could fix s/8a7779/r8a7779/ while >> applying... well, the USB patches haven't been ACK'ed yet. > I can fix that up. > Is the series waiting on anything? Probably on Felipe's ACKs on rcar-phy.c patches... Felipe hasn't appeared on this list for a week but I see his mails from today. >> >from r8a7779_add_standard_devices() anyway. >>> Note that I'm deliberately changing the USB PHY platform device's 'id' field >> >from (previously just omitted) 0 to -1 as the device is a single of its kind. >>> Note also that the board and SoC code have to be in one patch to keep the code >>> bisectable... >>> The patch has been tested on the Marzen board. >>> Signed-off-by: Sergei Shtylyov >>> Acked-by: Kuninori Morimoto >>> Acked-by: Simon Horman WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Mon, 22 Apr 2013 17:34:05 +0400 Subject: [PATCH v5 1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code In-Reply-To: <20130422010917.GC15680@verge.net.au> References: <201304200156.23830.sergei.shtylyov@cogentembedded.com> <51743BC0.20506@cogentembedded.com> <20130422010917.GC15680@verge.net.au> Message-ID: <51753C4D.4080701@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 22-04-2013 5:09, Simon Horman wrote: >>> USB EHCI, OHCI, and common PHY are the SoC devices but are wrongly defined and >>> registered in the Marzen board file. Move the data and code to their proper >>> place in setup-r8a7779.c; while at it, we have to rename 8a7779_late_devices[] >>> to 8a7779_standard_devices[] -- this seems legitimate since they are registered >> >> I've been pointed to the types in the above variable names privately. >> Don't know should I resend or Simon could fix s/8a7779/r8a7779/ while >> applying... well, the USB patches haven't been ACK'ed yet. > I can fix that up. > Is the series waiting on anything? Probably on Felipe's ACKs on rcar-phy.c patches... Felipe hasn't appeared on this list for a week but I see his mails from today. >> >from r8a7779_add_standard_devices() anyway. >>> Note that I'm deliberately changing the USB PHY platform device's 'id' field >> >from (previously just omitted) 0 to -1 as the device is a single of its kind. >>> Note also that the board and SoC code have to be in one patch to keep the code >>> bisectable... >>> The patch has been tested on the Marzen board. >>> Signed-off-by: Sergei Shtylyov >>> Acked-by: Kuninori Morimoto >>> Acked-by: Simon Horman WBR, Sergei