From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: linux-media@vger.kernel.org
Cc: kyungmin.park@samsung.com, sw0312.kim@samsung.com, a.hajda@samsung.com
Subject: Re: [PATCH 00/12] exynos4-is driver fixes
Date: Mon, 22 Apr 2013 16:13:17 +0200 [thread overview]
Message-ID: <5175457D.4050408@samsung.com> (raw)
In-Reply-To: <1366639427-14253-1-git-send-email-s.nawrocki@samsung.com>
On 04/22/2013 04:03 PM, Sylwester Nawrocki wrote:
> This patch series includes fixes for several issues found during
> testing all exynos4-is device drivers build as modules. The exynos4-is
> build with all sub-drivers as 'M' is hopefully now free of all serious
> issues, but one. I.e. the requirement now is to have all sub-device
> drivers, including the sensor subdev drivers, built as modules.
Hmm, to avoid issues all drivers must now be either statically linked or
build as modules and all need to be inserted, the all removed. Leaving
any one loaded all time may lead to a disaster... This is not a new
issue and and is related to all drivers using MC framework, thus I plan
to address it for 3.11.
> The problem when some of the sub-device drivers is statically linked
> is that the media links of a media entity just unregistered from
> the media device are not fully cleaned up in the media controller
> API. This means other entities can have dangling pointers to the links
> array owned by en entity just removed and freed. The problem is not
> existent when all media entites are registered/unregistred together.
> In such a case it doesn't hurt that media_entity_cleanup() function
> just frees the links array.
>
> I will post a separate RFC patch to address this issue, since it is
> not trivial where the link references should be removed from all
> involved media entities.
>
> I verified that adding a call to media_entity_remove_links() as in
> patch [1] to the v4l2_sdubdev_unregister_function() eliminates all
> weird crashes present before, when inserting/removing all the host
> driver modules while the sensor driver stays loaded.
>
> [1] http://git.linuxtv.org/snawrocki/samsung.git/commitdiff/f7007880a37c28beef845aa0787696aa8cead1cd
prev parent reply other threads:[~2013-04-22 14:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 14:03 [PATCH 00/12] exynos4-is driver fixes Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 01/12] s5c73m3: Fix remove() callback to free requested resources Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 02/12] s5c73m3: Add missing subdev .unregistered callback Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 03/12] exynos4-is: Remove redundant MODULE_DEVICE_TABLE entries Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 04/12] exynos4-is: Fix initialization of subdev 'flags' field Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 05/12] exynos4-is: Fix regulator/gpio resource releasing on the driver removal Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 06/12] exynos4-is: Don't overwrite subdevdata in the fimc-is sensor driver Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 07/12] exynos4-is: Unregister fimc-is subdevs from the media device properly Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 08/12] exynos4-is: Set fimc-lite subdev subdev owner module Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 09/12] exynos4-is: Remove redundant module_put() for MIPI-CSIS module Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 10/12] exynos4-is: Remove debugfs entries properly Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 11/12] exynos4-is: Change function call order in fimc_is_module_exit() Sylwester Nawrocki
2013-04-22 14:03 ` [PATCH 12/12] exynos4-is: Fix runtime PM handling on fimc-is probe error path Sylwester Nawrocki
2013-04-22 14:13 ` Sylwester Nawrocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175457D.4050408@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=a.hajda@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.