From: Felix Fietkau <nbd@openwrt.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] cfg80211: add support for per-chain signal strength reporting
Date: Mon, 22 Apr 2013 16:24:27 +0200 [thread overview]
Message-ID: <5175481B.5070203@openwrt.org> (raw)
In-Reply-To: <1366639439.8637.20.camel@jlt4.sipsolutions.net>
On 2013-04-22 4:03 PM, Johannes Berg wrote:
> On Sat, 2013-04-20 at 14:33 +0200, Felix Fietkau wrote:
>
>> + * @NL80211_STA_INFO_CHAIN_SIGNAL: per-chain signal strength of last PPDU
>> + * @NL80211_STA_INFO_CHAIN_SIGNAL_AVG: per-chain signal strength average
>
> please document the units/data structure (nested) here
Will do.
>> + if (nla_put_u8(msg, i, signal[i]))
>> + return false;
>
> does u8 make sense? it takes the same space as u32.
I used u8 because the other signal strength attributes also use u8.
- Felix
prev parent reply other threads:[~2013-04-22 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-20 12:33 [PATCH 1/2] cfg80211: add support for per-chain signal strength reporting Felix Fietkau
2013-04-20 12:33 ` [PATCH 2/2] mac80211: " Felix Fietkau
2013-04-22 14:03 ` [PATCH 1/2] cfg80211: " Johannes Berg
2013-04-22 14:24 ` Felix Fietkau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175481B.5070203@openwrt.org \
--to=nbd@openwrt.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.