From: "Andreas Färber" <afaerber@suse.de>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 7/7] use libusb for usb-host
Date: Mon, 22 Apr 2013 17:57:49 +0200 [thread overview]
Message-ID: <51755DFD.7040904@suse.de> (raw)
In-Reply-To: <87txn4t2b6.fsf@blackfin.pond.sub.org>
Am 18.04.2013 15:07, schrieb Markus Armbruster:
> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> Reimplement usb-host on top of libusb.
>> Reasons to do this:
>>
>> (1) Largely rewritten from scratch, nice opportunity to kill historical
>> cruft.
>> (2) Offload usbfs handling to libusb.
>> (3) Have a single portable code base instead of bsd + linux variants.
>> (4) Bring usb-host support to any platform supported by libusbx.
>>
>> For now this goes side-by-side to the existing code. That is only to
>> simplify regression testing though, at the end of the day I want remove
>> the old code and support libusb exclusively. Merge early in 1.5 cycle,
>> remove the old code after 1.5 release or something like this.
>>
>> Thanks to qdev the old and new code can coexist nicely on linux. Just
>> use "-device usb-host-linux" to use the old linux driver instead of the
>> libusb one (which takes over the "usb-host" name).
>>
>> The bsd driver isn't qdev'ified so it isn't that easy for bsd.
>> I didn't bother making it runtime switchable, so you have to rebuild
>> qemu with --disable-libusb to get back the old code.
>
> Breaks the build for me (Fedora 17's libusb1-devel-1.0.9-0.6.rc1):
>
> CC hw/usb/host-libusb.o
> /home/armbru/work/qemu/hw/usb/host-libusb.c:1254:217: error: ‘LIBUSB_LOG_LEVEL_WARNING’ undeclared here (not in a function)
Same on openSUSE 12.3 (1.0.9-5.1.1) - any fix cooking for this, Gerd?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-04-22 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 10:13 [Qemu-devel] [PULL 0/7] usb patch queue Gerd Hoffmann
2013-04-16 10:13 ` [Qemu-devel] [PATCH 1/7] usb-serial: Remove double call to qemu_chr_add_handlers( NULL ) Gerd Hoffmann
2013-04-16 10:13 ` [Qemu-devel] [PATCH 2/7] xhci: remove leftover debug printf Gerd Hoffmann
2013-04-16 10:13 ` [Qemu-devel] [PATCH 3/7] xhci: add xhci_cap_write Gerd Hoffmann
2013-04-16 10:13 ` [Qemu-devel] [PATCH 4/7] xhci: fix portsc writes Gerd Hoffmann
2013-04-16 10:13 ` [Qemu-devel] [PATCH 5/7] xhci: use slotid as device address Gerd Hoffmann
2013-04-16 10:13 ` [Qemu-devel] [PATCH 6/7] xhci: fix address device Gerd Hoffmann
2013-04-16 10:13 ` [Qemu-devel] [PATCH 7/7] use libusb for usb-host Gerd Hoffmann
2013-04-18 13:07 ` Markus Armbruster
2013-04-22 15:57 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51755DFD.7040904@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.