From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Subject: Re: [PATCH] rbd: revalidate_disk upon rbd resize Date: Mon, 22 Apr 2013 12:35:19 -0500 Message-ID: <517574D7.3030004@inktank.com> References: <1365774766-29899-1-git-send-email-laurent@ksperis.com> <516C37D5.1090804@inktank.com> <51756F11.6050708@inktank.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ia0-f171.google.com ([209.85.210.171]:48354 "EHLO mail-ia0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753870Ab3DVRfW (ORCPT ); Mon, 22 Apr 2013 13:35:22 -0400 Received: by mail-ia0-f171.google.com with SMTP id f27so5613300iae.2 for ; Mon, 22 Apr 2013 10:35:21 -0700 (PDT) In-Reply-To: Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Sage Weil Cc: Laurent Barbe , ceph-devel@vger.kernel.org On 04/22/2013 12:14 PM, Sage Weil wrote: > On Mon, 22 Apr 2013, Alex Elder wrote: >> On 04/15/2013 12:24 PM, Alex Elder wrote: >>> On 04/12/2013 08:52 AM, Laurent Barbe wrote: >>>> If rbd disk is open and rbd resize is done, new size is not visible by >>>> filesystem. >>>> Like is done in virtio-blk and dm driver, revalidate_disk() permits to >>>> update the bd_inode size. >>>> >>>> Signed-off-by: Laurent Barbe >>> >>> This one looks good (too). And this time I've tested >>> it just to be sure I get no lockdep warnings. Unless >>> I see any strangeness in my sanity testing (which I >>> don't expect) I'll commit this to the testing branch >>> later today. Thanks a lot. >>> >>> Reviewed-by: Alex Elder >> >> I have committed this to the "testing" branch of the >> ceph-client git repository. > > Is this the one that had the lockdep issue? It did, but moving where it got called (into rbd_dev_refresh(), outside the control mutex) resolved that. -Alex