From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/4] arm: remove incorrect dcache flush at start of day. Date: Mon, 22 Apr 2013 18:43:52 +0100 Message-ID: <517576D8.6090304@citrix.com> References: <1366648964.20256.24.camel@zakaz.uk.xensource.com> <1366648985-26435-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1366648985-26435-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Sengul Thomas , Stefano Stabellini , "Tim (Xen.org)" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 04/22/2013 05:43 PM, Ian Campbell wrote: > flush_xen_dcache flushes by virtual address and at this point boot_ttbr > contains a physical address. I think this part of the comment is wrong. flush_xen_dcache will flush the address of boot_ttbr, not the one contains in the variable. > The actual virtual address of the root pagetable is within the region flushed > by the following flush of the _start to _end range. > > Signed-off-by: Ian Campbell > --- > xen/arch/arm/mm.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index ba3140d..0801239 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -306,7 +306,6 @@ void __init setup_pagetables(unsigned long boot_phys_offset, paddr_t xen_paddr) > > /* Change pagetables to the copy in the relocated Xen */ > boot_ttbr = (uintptr_t) xen_pgtable + phys_offset; > - flush_xen_dcache(boot_ttbr); > flush_xen_dcache_va_range((void*)dest_va, _end - _start); > flush_xen_text_tlb(); >