From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] zlib: fix compilation failures with Sun C Compilaer
Date: Mon, 22 Apr 2013 19:50:02 +0200 [thread overview]
Message-ID: <5175784A.5060805@gmail.com> (raw)
In-Reply-To: <7vfvyipl4f.fsf@alter.siamese.dyndns.org>
On 04/22/2013 06:48 PM, Junio C Hamano wrote:
> Stefano Lattarini <stefano.lattarini@gmail.com> writes:
>
>> Do this by removing a couple of useless return statements. Without this
>> change, compilation with Sun C Compiler 5.9 (SunOS_i386 Patch 124868-15
>> 2010/08/11) fails with the following message:
>>
>> "zlib.c", line 192: void function cannot return value
>> "zlib.c", line 201: void function cannot return value
>> cc: acomp failed for zlib.c
>
> Thanks for catching a recent regression in the mainline before any
> tagged release is made out of it. Very much appreciated.
>
Actually, I tried to build the bleeding-edge git on Solaris to use it
myself, rather than to test it ;-) So, thanks to you and all the git
contributors for continuously improving the package, thus making it
worth to try to build and use the bleeding-edge version.
Best regards,
Stefano
next prev parent reply other threads:[~2013-04-22 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 16:18 [PATCH] zlib: fix compilation failures with Sun C Compilaer Stefano Lattarini
2013-04-22 16:48 ` Junio C Hamano
2013-04-22 17:50 ` Stefano Lattarini [this message]
2013-04-22 16:54 ` René Scharfe
2013-04-22 21:41 ` Eric Sunshine
2013-04-22 22:06 ` Stefano Lattarini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175784A.5060805@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.