From mboxrd@z Thu Jan  1 00:00:00 1970
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH 5/6] x86: enable multi-vector MSI
Date: Mon, 22 Apr 2013 19:55:37 -0500
Message-ID: <5175DC09.8090707@amd.com>
References: <51713D8F02000078000CEEE6@nat28.tlf.novell.com>
	<51713FCF02000078000CEF27@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <51713FCF02000078000CEF27@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Jacob Shin <jacob.shin@amd.com>, xiantao.zhang@intel.com, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 4/19/2013 5:59 AM, Jan Beulich wrote:
> --- a/xen/arch/x86/msi.c
> +++ b/xen/arch/x86/msi.c
> @@ -238,6 +238,11 @@ static int write_msi_msg(struct msi_desc
>           u8 bus = dev->bus;
>           u8 slot = PCI_SLOT(dev->devfn);
>           u8 func = PCI_FUNC(dev->devfn);
> +        int nr = entry->msi_attrib.entry_nr;
> +
> +        ASSERT((msg->data & (entry[-nr].msi.nvec - 1)) == nr);
> +        if ( nr )
> +            return 0;
>   
Jan,

This logic seems incorrect.  Do you meant to write --nr?  This causes 
assertion here.  Also, investigation showing the value of nr is 0 here.

Suravee