From: linux@prisktech.co.nz (Tony Prisk)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 12/13] ARM: mach-vt8500: cpus/cpu nodes dts updates
Date: Tue, 23 Apr 2013 14:43:48 +1200 [thread overview]
Message-ID: <5175F564.8030405@prisktech.co.nz> (raw)
In-Reply-To: <1366644455-16550-13-git-send-email-lorenzo.pieralisi@arm.com>
On 23/04/13 03:27, Lorenzo Pieralisi wrote:
> This patch updates the in-kernel dts files according to the latest cpus
> and cpu bindings updates for ARM.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> ---
> arch/arm/boot/dts/wm8505.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi
> index e74a1c0..a470808 100644
> --- a/arch/arm/boot/dts/wm8505.dtsi
> +++ b/arch/arm/boot/dts/wm8505.dtsi
> @@ -13,7 +13,7 @@
>
> cpus {
> cpu at 0 {
> - compatible = "arm,arm926ejs";
> + compatible = "arm,arm926";
> };
> };
>
The more I look at this, the more wrong it is :/
From the new binding documentation,
+ A cpus node must define the following properties:
+
+ - #address-cells
+ Usage: required
+ Value type: <u32>
+ Definition: must be set to 1 for 32-bit systems and 2 for
+ 64-bit systems
+ - #size-cells
+ Usage: required
+ Value type: <u32>
+ Definition: must be set to 0
...
+- cpu node
+
+ Description: Describes a CPU in an ARM based system
+
+ PROPERTIES
+
+ - device_type
+ Usage: required
+ Value type: <string>
+ Definition: must be "cpu"
Three required properties that aren't present in the patch.
cpus {
#size-cells = <0>;
#address-cells = <1>;
cpu {
device_type = "cpu"
compatible = "arm,arm926";
};
};
Regards
Tony P
WARNING: multiple messages have this Message-ID (diff)
From: Tony Prisk <linux-ci5G2KO2hbZ+pU9mqzGVBQ@public.gmane.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
Cc: Nicolas Pitre
<nicolas.pitre-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Jon Medhurst <tixy-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
Lennert Buytenhek
<kernel-OLH4Qvv75CYX/NnBR394Jw@public.gmane.org>,
Kukjin Kim <kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Viresh Kumar
<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
David Brown <davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Barry Song <baohua.song-kQvG35nSl+M@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Amit Kucheria
<amit.kucheria-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Vinayak Kale <vkale-qTEPVZfXA3Y@public.gmane.org>
Subject: Re: [RFC PATCH v2 12/13] ARM: mach-vt8500: cpus/cpu nodes dts updates
Date: Tue, 23 Apr 2013 14:43:48 +1200 [thread overview]
Message-ID: <5175F564.8030405@prisktech.co.nz> (raw)
In-Reply-To: <1366644455-16550-13-git-send-email-lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
On 23/04/13 03:27, Lorenzo Pieralisi wrote:
> This patch updates the in-kernel dts files according to the latest cpus
> and cpu bindings updates for ARM.
>
> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>
> ---
> arch/arm/boot/dts/wm8505.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/wm8505.dtsi b/arch/arm/boot/dts/wm8505.dtsi
> index e74a1c0..a470808 100644
> --- a/arch/arm/boot/dts/wm8505.dtsi
> +++ b/arch/arm/boot/dts/wm8505.dtsi
> @@ -13,7 +13,7 @@
>
> cpus {
> cpu@0 {
> - compatible = "arm,arm926ejs";
> + compatible = "arm,arm926";
> };
> };
>
The more I look at this, the more wrong it is :/
From the new binding documentation,
+ A cpus node must define the following properties:
+
+ - #address-cells
+ Usage: required
+ Value type: <u32>
+ Definition: must be set to 1 for 32-bit systems and 2 for
+ 64-bit systems
+ - #size-cells
+ Usage: required
+ Value type: <u32>
+ Definition: must be set to 0
...
+- cpu node
+
+ Description: Describes a CPU in an ARM based system
+
+ PROPERTIES
+
+ - device_type
+ Usage: required
+ Value type: <string>
+ Definition: must be "cpu"
Three required properties that aren't present in the patch.
cpus {
#size-cells = <0>;
#address-cells = <1>;
cpu {
device_type = "cpu"
compatible = "arm,arm926";
};
};
Regards
Tony P
next prev parent reply other threads:[~2013-04-23 2:43 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 15:27 [RFC PATCH v2 00/13] ARM: DT cpu bindings updates Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-22 15:27 ` [RFC PATCH v2 01/13] ARM: DT: kernel: move temporary cpu map stack array to static data Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-22 15:27 ` [RFC PATCH v2 02/13] ARM: mach-mv78xx0: cpus/cpu node dts updates Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-22 15:27 ` [RFC PATCH v2 03/13] ARM: mach-at91: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-22 15:48 ` Nicolas Ferre
2013-04-22 15:48 ` Nicolas Ferre
2013-04-23 13:11 ` Rob Herring
2013-04-23 13:11 ` Rob Herring
2013-04-23 13:25 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-23 13:25 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-23 13:53 ` Lorenzo Pieralisi
2013-04-23 13:53 ` Lorenzo Pieralisi
2013-04-23 19:52 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-23 19:52 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-24 9:29 ` Lorenzo Pieralisi
2013-04-24 9:29 ` Lorenzo Pieralisi
2013-04-24 12:45 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-24 12:45 ` Jean-Christophe PLAGNIOL-VILLARD
2013-04-22 15:27 ` [RFC PATCH v2 04/13] ARM: mach-exynos: cpus/cpu nodes " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-22 15:27 ` [RFC PATCH v2 05/13] ARM: mach-imx: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-23 7:34 ` Shawn Guo
2013-04-23 7:34 ` Shawn Guo
2013-04-22 15:27 ` [RFC PATCH v2 06/13] ARM: mach-lpc32xx: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-22 15:27 ` [RFC PATCH v2 07/13] ARM: mach-omap2: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-22 15:27 ` [RFC PATCH v2 08/13] ARM: mach-picoxcell: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-22 15:27 ` [RFC PATCH v2 09/13] ARM: mach-shmobile: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-23 1:55 ` Simon Horman
2013-04-23 1:55 ` Simon Horman
2013-04-22 15:27 ` [RFC PATCH v2 10/13] ARM: mach-spear: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-23 6:18 ` Viresh Kumar
2013-04-23 6:18 ` Viresh Kumar
2013-04-22 15:27 ` [RFC PATCH v2 11/13] ARM: mach-sunxi: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-24 7:15 ` Maxime Ripard
2013-04-24 7:15 ` Maxime Ripard
2013-04-22 15:27 ` [RFC PATCH v2 12/13] ARM: mach-vt8500: " Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-23 2:13 ` Tony Prisk
2013-04-23 2:13 ` Tony Prisk
2013-04-23 2:20 ` Tony Prisk
2013-04-23 2:20 ` Tony Prisk
2013-04-23 9:16 ` Lorenzo Pieralisi
2013-04-23 9:16 ` Lorenzo Pieralisi
2013-04-23 9:15 ` Lorenzo Pieralisi
2013-04-23 9:15 ` Lorenzo Pieralisi
2013-04-23 2:43 ` Tony Prisk [this message]
2013-04-23 2:43 ` Tony Prisk
2013-04-23 9:26 ` Lorenzo Pieralisi
2013-04-23 9:26 ` Lorenzo Pieralisi
2013-04-22 15:27 ` [RFC PATCH v2 13/13] ARM: DT: kernel: DT cpu node bindings update Lorenzo Pieralisi
2013-04-22 15:27 ` Lorenzo Pieralisi
2013-04-23 2:46 ` Tony Prisk
2013-04-23 2:46 ` Tony Prisk
2013-05-02 18:31 ` Stephen Warren
2013-05-02 18:31 ` Stephen Warren
2013-05-03 9:15 ` Lorenzo Pieralisi
2013-05-03 9:15 ` Lorenzo Pieralisi
2013-04-22 16:41 ` [RFC PATCH v2 00/13] ARM: DT cpu bindings updates Will Deacon
2013-04-22 16:41 ` Will Deacon
2013-04-22 18:00 ` Lorenzo Pieralisi
2013-04-22 18:00 ` Lorenzo Pieralisi
2013-04-22 19:18 ` Arnd Bergmann
2013-04-22 19:18 ` Arnd Bergmann
2013-04-23 9:09 ` Will Deacon
2013-04-23 9:09 ` Will Deacon
2013-04-23 9:34 ` Lorenzo Pieralisi
2013-04-23 9:34 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175F564.8030405@prisktech.co.nz \
--to=linux@prisktech.co.nz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.