From: DuanZhenzhong <zhenzhong.duan@oracle.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: memcpy_fromio in dmi_scan.c
Date: Tue, 23 Apr 2013 11:25:03 +0800 [thread overview]
Message-ID: <5175FF0F.9050206@oracle.com> (raw)
In-Reply-To: <1366636689.4503.35.camel@chaos.site>
Jean Delvare wrote:
> Hi Duan, Andrew,
>
> I am looking at the following commit:
>
> commit 9f9c9cbb60576a1518d0bf93fb8e499cffccf377
> Author: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> Date: Thu Dec 20 15:05:14 2012 -0800
>
> drivers/firmware/dmi_scan.c: fetch dmi version from SMBIOS if it exists
>
> And I am worried about calls to memcpy_fromio(), or lack thereof. Before
> this commit, the code would take great care to always call
> memcpy_fromio() to get data from the 0xF0000-0xFFFFF memory range (BIOS
> data) and operate on that copy. After this commit, the code is happily
> calling memcmp() directly on an __iomem pointer. It seems to be harmless
> on x86, but it will break on IA64, won't it?
>
>
Hi Jean,
What's the impact of reading bios data directly on IA64?
Sorry I have little knowledge about IA64.
zduan
next prev parent reply other threads:[~2013-04-23 3:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 13:18 memcpy_fromio in dmi_scan.c Jean Delvare
2013-04-23 3:25 ` DuanZhenzhong [this message]
2013-04-23 7:28 ` Jean Delvare
2013-04-23 22:00 ` Luck, Tony
2013-04-24 19:22 ` Jean Delvare
2013-04-24 20:16 ` Luck, Tony
2013-04-25 2:07 ` Robin Holt
2013-04-25 9:52 ` Robin Holt
2013-04-25 20:37 ` Andrew Morton
2013-07-08 13:54 ` Jean Delvare
2013-04-25 1:51 ` Zhenzhong Duan
2013-04-25 10:02 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5175FF0F.9050206@oracle.com \
--to=zhenzhong.duan@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.